Skip to content

GitLab

I
iotivity-classic
Open
Opened by Rami Alshafi@ramiOwner

[SM][API][Linux][Local][Remote] Several APIs allow empty string as an attribute's key

Several APIs allow empty string as attribute's key. Their descriptions are given below :-

  1. [SM][Local]addNewSceneAction api
    [Procedure]

  2. Create light and fan type resource

  3. Get SceneList instance

  4. Get SceneCollection pointer by adding SceneCollection

  5. Get scene pointer by adding scene

  6. Call addNewSceneAction(const RCSRemoteResourceObject:
    tr& pRCSRemoteResourceObject,std::string key, RCSResourceAttributes::Value value) with empty string as attribute's key
    [Expected]

addNewSceneAction api should not allow empty string as attribute's key
[Actual]

It allows empty string as attribute's key and throws no exceptions
2. [SM][Remote]addNewSceneAction api
[Procedure]

  1. Create light and fan type resource and local sceneList resource

  2. Get Remote SceneList instance by calling createInstance method

  3. Get Remote SceneCollection pointer by adding SceneCollection

  4. Get Remote scene pointer by adding scene

  5. Call addNewSceneAction(RCSRemoteResourceObject:
    tr targetResource,const std::string &key,const RCSResourceAttributes::Value &value,AddNewSceneActionCallback cb)with empty string as attribute's key
    [Expected]

addNewSceneAction api should not allow empty string as attribute's key
[Actual]

It allows empty string as attribute's key and throws no exceptions
3. [SM][Local]resetExecutionParameter api
[Procedure]

  1. Create light and fan type resource

  2. Get SceneList instance

  3. Get SceneCollection pointer by adding SceneCollection

  4. Get scene pointer by adding scene

  5. Get SceneAction pointer by adding sceneAction

  6. Call resetExecutionParameter(const std::string& key, RCSResourceAttributes::Value value) with empty string as attribute's key
    [Expected]

resetExecutionParameter api should not allow empty string as attribute's key
[Actual]

It allows empty string as attribute's key and throws no exceptions
4. [SM][Remote]resetExecutionParameter api
[Procedure]

  1. Create light and fan type resource and local sceneList resource

  2. Get Remote SceneList instance by calling createInstance method

  3. Get Remote SceneCollection pointer by adding SceneCollection

  4. Get Remote scene pointer by adding scene

  5. Get Remote SceneAction pointer by adding sceneAction

  6. Call resetExecutionParameter(const std::string &key,const RCSResourceAttributes::Value &value, ResetExecutionParameterCallback cb) with empty string as attribute's key
    [Expected]

resetExecutionParameter api should not allow empty string as attribute's key
[Actual]

It allows empty string as attribute's key and throws no exceptions

JIRA migration meta data

  • JIRA Issue ID: IOT-1012
  • Reporter: aman90
  • Assignee: jihun.ha
  • Creator: aman90
  • Created at: 2016-03-22T04:30:41.000-0700
  • Found in Version: 22932f7a
  • Fix in Version: None
  • Issue Severity: Minor
  • Reproducibility: Always (100%)
  • Operating System: Ubuntu
  • Hardware/ OEM Platform: None
  • External URL:
    https://gerrit.iotivity.org/gerrit/#/c/6243/
  • Bugzilla ID: None
  • Product: None
  • Status: Closed
  • Components: SDK
  • Priority: P3
  • Due Date: None
  • Issue Type: Bug
    END of JIRA migration meta data