Skip to content

GitLab

I
iotivity-classic
Switch branch/tag
  1. 23 Nov, 2017 2 commits
    • Senthil Kumar G S's avatar
      [IOT-2906][ES] Remove "href" from child response. · d698f81a
      Senthil Kumar G S authored 
      For requests which come directly to child resources
(/WiFiConfResURI, /CoapCloudConfResURI and /DevConfResURI),
this patch will remove the "href" property from the response
as spec doesn't mandate the addition of "href" in the response.

And also, CTT expects the response from direct request to any child
to be same as the response which comes for the same child
through collection.

For example:
Properties in "rep" for '/WiFiConfResURI' should be same as
the properties in the direct response for GET from '/WiFiConfResURI' resource.

Currently "href" is not included in "rep" for child resources.
But it is included in the direct response for GET/POST.
When CTT compares both responses, it finds them different due of "href".

This patch resolves the issue and still conforms to spec.

Change-Id: I017bed18d3e0ad568b662a03d9bd80134538a8c0
Signed-off-by: default avatarSenthil Kumar G S <senthil.gs@samsung.com>
      d698f81a
    • Senthil Kumar G S's avatar
      [IOT-2904][ES] Fix for issues found through CTT. · fb2e25fc
      Senthil Kumar G S authored 
      1. If one of the resources in the POST request over batch
has invalid properties, then the response should include an
empty "rep" for those resources.
For all other resources with valid properties in the request,
"rep" should include all the properties.

2. Allowing "cn" property to be set to ES_CONNECT_NONE.

Change-Id: Ib819bed7a126717cc56df0fb32b3d9f3ec570682
Signed-off-by: default avatarSenthil Kumar G S <senthil.gs@samsung.com>
      fb2e25fc
  3. 20 Nov, 2017 2 commits
  5. 08 Nov, 2017 1 commit
    • Ibrahim Esmat's avatar
      Cherry Pick change to enable building with SCons3 · e5418f06
      Ibrahim Esmat authored 
      Cherry Pick Mats change from master to enable building with SCons 3.0
in 1.3-rel branch. This change and the change in review
https://gerrit.iotivity.org/gerrit/#/c/22809 will be needed to merge
together.

With these 2 changes merged to 1.3-rel, you can successfully build
IoTivity with SCons 3.0. Which will also allow you to build the
UWP versions of the libraries needed for UWP Apps.

Change in master:
Prepare for scons3: change prints and others

In preparation for scons3, recently released, modify remaining print
statements by surrounding them with parens so they look like function
calls. That takes care of the scons3 syntax requirement.

The remaining instances of the sequence "print FOO; Exit(1)" were
changed to "msg = FOO; Exit(msg)" - this helps with the change by
not even using the print statement, and by giving the message to
the output function, it is sent to the error stream rather than
the output stream.

Calls to dictionary keys() and values() are now wrapped in list(),
on Python 3 these return special objects, not the expected list.
That's harmless to Python 2 usage.

The old exception format "except FooErr, err" is no longer supported;
since the Python 3 format "except FooErr as err" has been available
since Python 2.6, there is no problem switching these.

Some instances of using the commands module in extlibs changes to use
subprocess module. Change is transparent.

A couple of instances of filter(lambda ...)) were changes to
a python list comprehension, this is considered preferred for
Python 3 (change was suggested by a conversion tool)

Note on print() change:

  When running with Python2, the print statement is still used. That
  has a bit of an impact: print(a) is just prints the argument, but
  print(a, b, c) is interpreted as printing a tuple (a, b, c), so we
  could see:

  >>> print "This", "is", "a", "test"
  This is a test
  >>> print("This", "is", "a", "test")
  ('This', 'is', 'a', 'test')

  The second is not pretty.  You can make Python2 code use the function
  instead of the statement:

  >>> from __future__ import print_function
  >>> print("This", "is", "a", "test")
  This is a test

  but that's a pain, so the small number of existing prints which
  used a comma as argument separators were updated to use addition,
  so now we're concatenating a string to produce one arg instead
  of supplying multiple "arguments" that would be misinterpreted
  as a tuple in print().  It's fine to add the import statement
  if it's needed.

Change-Id: Idac00e1389b79ee65da4a2eb6ef3246551b66843
Signed-off-by: default avatarMats Wichmann <mats@linux.com>
Signed-off-by: default avatarIbrahim Esmat <iesmat@microsoft.com>
      e5418f06
  7. 06 Nov, 2017 1 commit
  9. 30 Oct, 2017 2 commits
  11. 23 Oct, 2017 1 commit
  13. 19 Oct, 2017 1 commit
  15. 18 Oct, 2017 3 commits
  17. 17 Oct, 2017 2 commits
  19. 15 Oct, 2017 2 commits
  21. 13 Oct, 2017 2 commits
  23. 04 Oct, 2017 2 commits
  25. 28 Sep, 2017 2 commits
  27. 27 Sep, 2017 1 commit
  29. 26 Sep, 2017 2 commits
  31. 19 Sep, 2017 1 commit
    • George Nash's avatar
      provisioning: Fixed memory leak · dab3e302
      George Nash authored 
      Fixed memory leak found using valgrind. The memory
leak was due to the provisionInit function calling
sqlite3_open_v2 without calling sqlite3_close

There was not provisionClose method in the C++ so it was
added to the OCSecure class. To do this OCClosePM was
also added to that the code could be used in Windows.

The provisioningClose call was added to all of the samples
that are currently calling provisioningInit(dbfile)

While updating the some of the android samples the
tab depth was cleaned.

Note the unit tests are not following one of the most
basic rules of unit testing. Tests should be isolated
and independent. When the cleanup code was added to the
unit tests it broke tests that run later. Each individual
unit test should be able to run independent of all the
other unit tests order should not matter. This commit
does a little to break the dependency tests have on other
tests, but it did not fix it completely. Many tests rely
on the DB being left in a state by another test as well as
passing test state to global variables that hold information
outside the individual test.

Change-Id: Id2c05ecc611516a5cf892ae70bb4e0cd0c115752
Signed-off-by: George Nash's avatarGeorge Nash <george.nash@intel.com>
      dab3e302
  33. 18 Sep, 2017 1 commit
  35. 15 Sep, 2017 2 commits
  37. 13 Sep, 2017 2 commits
    • Ankur Bansal's avatar
      [IOT-2628][EasySetup]Add new prop. swat,swet · 5617a85d
      Ankur Bansal authored 
      Add new mandatory properties to oic.r.wificonf
- swat: Enrollee's supported Wi-Fi Authentication Types
- swet: Enrollee's supported Wi-Fi Encryption Types
- Update Enrollee sample apps (Linux and Tizen).

Note: This impacts Easy Setup Enrollee API "ESSetDeviceProperty".

Change-Id: Ic765671dfbe3a4e1c8a857ef6ae1d3dcb9ba783e
Signed-off-by: default avatarAnkur Bansal <ankur.b1@samsung.com>
      5617a85d
    • Ankur Bansal's avatar
      [IOT-2628][EasySetup]Update WifiConf prop. types · 132838c4
      Ankur Bansal authored 
      - Change properties from integer to string enums: swmt, swf, wat, wet
- Change supported frequencies from single value to array.
- Create type converters for enum to string and string to enum.
- Remove EOF marker in enum WIFI_MODE.
- Update Enrollee sample apps (Linux and Tizen).
- Cleanup some unused code in easysetup.c.
- Fixed unit test cases for Enrollee and Mediator.

Note: This impacts Easy Setup Enrollee API "ESSetDeviceProperty".

Thanks-To: Abhishek Pandey <abhi.siso@samsung.com>
Change-Id: Iea8191616cea89a0273e0f5486bd259735e914fa
Signed-off-by: default avatarAbhishek Pandey <abhi.siso@samsung.com>
Signed-off-by: default avatarAnkur Bansal <ankur.b1@samsung.com>
      132838c4
  39. 11 Sep, 2017 1 commit
  41. 07 Sep, 2017 1 commit
  43. 06 Sep, 2017 1 commit
  45. 29 Aug, 2017 1 commit
  47. 18 Aug, 2017 1 commit
  49. 02 Aug, 2017 1 commit
  51. 31 Jul, 2017 1 commit
  53. 28 Jun, 2017 1 commit