1. 23 Nov, 2017 2 commits
    • Senthil Kumar G S's avatar
      [IOT-2906][ES] Remove "href" from child response. · d698f81a
      Senthil Kumar G S authored
      For requests which come directly to child resources
      (/WiFiConfResURI, /CoapCloudConfResURI and /DevConfResURI),
      this patch will remove the "href" property from the response
      as spec doesn't mandate the addition of "href" in the response.
      
      And also, CTT expects the response from direct request to any child
      to be same as the response which comes for the same child
      through collection.
      
      For example:
      Properties in "rep" for '/WiFiConfResURI' should be same as
      the properties in the direct response for GET from '/WiFiConfResURI' resource.
      
      Currently "href" is not included in "rep" for child resources.
      But it is included in the direct response for GET/POST.
      When CTT compares both responses, it finds them different due of "href".
      
      This patch resolves the issue and still conforms to spec.
      
      Change-Id: I017bed18d3e0ad568b662a03d9bd80134538a8c0
      Signed-off-by: default avatarSenthil Kumar G S <senthil.gs@samsung.com>
      d698f81a
    • Senthil Kumar G S's avatar
      [IOT-2904][ES] Fix for issues found through CTT. · fb2e25fc
      Senthil Kumar G S authored
      1. If one of the resources in the POST request over batch
      has invalid properties, then the response should include an
      empty "rep" for those resources.
      For all other resources with valid properties in the request,
      "rep" should include all the properties.
      
      2. Allowing "cn" property to be set to ES_CONNECT_NONE.
      
      Change-Id: Ib819bed7a126717cc56df0fb32b3d9f3ec570682
      Signed-off-by: default avatarSenthil Kumar G S <senthil.gs@samsung.com>
      fb2e25fc
  2. 20 Nov, 2017 2 commits
  3. 09 Nov, 2017 1 commit
  4. 08 Nov, 2017 1 commit
    • Ibrahim Esmat's avatar
      Cherry Pick change to enable building with SCons3 · e5418f06
      Ibrahim Esmat authored
      Cherry Pick Mats change from master to enable building with SCons 3.0
      in 1.3-rel branch. This change and the change in review
      https://gerrit.iotivity.org/gerrit/#/c/22809 will be needed to merge
      together.
      
      With these 2 changes merged to 1.3-rel, you can successfully build
      IoTivity with SCons 3.0. Which will also allow you to build the
      UWP versions of the libraries needed for UWP Apps.
      
      Change in master:
      Prepare for scons3: change prints and others
      
      In preparation for scons3, recently released, modify remaining print
      statements by surrounding them with parens so they look like function
      calls. That takes care of the scons3 syntax requirement.
      
      The remaining instances of the sequence "print FOO; Exit(1)" were
      changed to "msg = FOO; Exit(msg)" - this helps with the change by
      not even using the print statement, and by giving the message to
      the output function, it is sent to the error stream rather than
      the output stream.
      
      Calls to dictionary keys() and values() are now wrapped in list(),
      on Python 3 these return special objects, not the expected list.
      That's harmless to Python 2 usage.
      
      The old exception format "except FooErr, err" is no longer supported;
      since the Python 3 format "except FooErr as err" has been available
      since Python 2.6, there is no problem switching these.
      
      Some instances of using the commands module in extlibs changes to use
      subprocess module. Change is transparent.
      
      A couple of instances of filter(lambda ...)) were changes to
      a python list comprehension, this is considered preferred for
      Python 3 (change was suggested by a conversion tool)
      
      Note on print() change:
      
        When running with Python2, the print statement is still used. That
        has a bit of an impact: print(a) is just prints the argument, but
        print(a, b, c) is interpreted as printing a tuple (a, b, c), so we
        could see:
      
        >>> print "This", "is", "a", "test"
        This is a test
        >>> print("This", "is", "a", "test")
        ('This', 'is', 'a', 'test')
      
        The second is not pretty.  You can make Python2 code use the function
        instead of the statement:
      
        >>> from __future__ import print_function
        >>> print("This", "is", "a", "test")
        This is a test
      
        but that's a pain, so the small number of existing prints which
        used a comma as argument separators were updated to use addition,
        so now we're concatenating a string to produce one arg instead
        of supplying multiple "arguments" that would be misinterpreted
        as a tuple in print().  It's fine to add the import statement
        if it's needed.
      
      Change-Id: Idac00e1389b79ee65da4a2eb6ef3246551b66843
      Signed-off-by: default avatarMats Wichmann <mats@linux.com>
      Signed-off-by: default avatarIbrahim Esmat <iesmat@microsoft.com>
      e5418f06
  5. 06 Nov, 2017 1 commit
  6. 30 Oct, 2017 2 commits
  7. 27 Oct, 2017 2 commits
  8. 25 Oct, 2017 2 commits
    • George Nash's avatar
      IOT-2838 Fix javadoc warnings · 5cfded4d
      George Nash authored
      Documented all the functions referencing the native code.
      
      Note the OcProvisioning setPinType method had a return value
      int. The was returning the return value of the native call
      that was the status. Due to the way the code was writen the
      only value that could be returned was when things worked as
      expected. All other values were thrown so the return value
      was un-needed. The function was changed to have a return type
      of void.
      
      Bug:https://jira.iotivity.org/browse/IOT-2838
      Change-Id: I3b5955a336661574dde9f70c87b6ead3dcd5ea7b
      Signed-off-by: George Nash's avatarGeorge Nash <george.nash@intel.com>
      5cfded4d
    • George Nash's avatar
      IOT-2539 Enable the -Werror build flag · 418ccc66
      George Nash authored
      The coding standard states:
      Code must compile with no warnings. Without flags
      forcing warnings off.
      see:
      https://wiki.iotivity.org/iotivity_c_coding_standards
      
      Its possible that using an untested version of gcc could
      result in build warings that are not yet fixed. For this
      reason the build option ERROR_ON_WARN was added to make
      it possible to turn off the -Werror flag. This should
      only be used locally an not changed on the CI build.
      
      Due to some bugs in older version of gcc some warnings
      are forced off when using an older version of gcc.
      
      This change will force code to follow the coding
      standard of building with no warnings.
      
      The coapHttpParser code produces a build warning
      that currently is not solved. When building the
      coap_http_proxy library the -Werror build flag is
      removed.
      
      Don't use the -Werror build option for extlib yaml
      code.
      
      Don't use the -Werror build option for coap library
      
      Change-Id: Ifcc25ed7e5b8637ac4383a7bfa51ace105ed9458
      Signed-off-by: George Nash's avatarGeorge Nash <george.nash@intel.com>
      418ccc66
  9. 23 Oct, 2017 1 commit
  10. 19 Oct, 2017 9 commits
  11. 18 Oct, 2017 3 commits
  12. 17 Oct, 2017 3 commits
  13. 16 Oct, 2017 6 commits
  14. 15 Oct, 2017 2 commits
  15. 13 Oct, 2017 3 commits