- 04 May, 2017 4 commits
-
-
Dan Mihai authored
Test case CT1.7.2.1-2 from CTT v1.5.6 fails with "message mac does not match": - After CTT successfully posted the owner credential - While trying to establish a new DTLS session, using the new credential Change-Id: I282632d1071c76afba629081d6853d376c347473 Signed-off-by:
Dan Mihai <Daniel.Mihai@microsoft.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19515Reviewed-by:
Kevin Kane <kkane@microsoft.com> Reviewed-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com> Tested-by:
-
Nathan Heldt-Sheller authored
Implementation of CR 22 feature to deny UPDATE to /cred if any Property in the POST representation is read-only in the current /pstat.dos.s state. Change-Id: I2acb34b8ceff1eeba0a4b12101fa60d7c2dee9dc Signed-off-by:
jenkins-iotivity <jenkins@iotivity.org> Reviewed-by:
-
Srikrishna Gurugubelli authored
Change-Id: I5e6c0d1a016e409429498835587c73d5ef0b7fea Signed-off-by:
Srikrishna Gurugubelli <srikguru@microsoft.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19513Tested-by:
-
Soemin Tjong authored
This addresses the scenario where the app needs to be certain when all callbacks related to the handle it is closing are completed. Change-Id: I75b211d477405be27c6c804bc89e529088aa1a90 Signed-off-by:
Soemin Tjong <stjong@microsoft.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/18217Tested-by:
-
- 03 May, 2017 4 commits
-
-
Poovizhi authored
The roomserver app crashes due to Invalid free in ocserverrequest.c Flow: sendResponse->OCDoResponse->HandleAggregateResponse->DeleteServerResponse->OCPayloadDestroy The payload is already freed in the caller function of sendResponse in InProcServerWrapper.cpp OCPayloadDestroy is called twice during sendResponse causing a crash in the app. Hence removing the OCPayloadDestroy called in the method DeleteServerResponse Change-Id: If8155238120789736c39b396b65989a2dfc59ded Signed-off-by:
Poovizhi <poovizhi.a@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19155Tested-by:
Ashok Babu Channa <ashok.channa@samsung.com> Reviewed-by:
Uze Choi <uzchoi@samsung.com> Reviewed-by:
Phil Coval <philippe.coval@osg.samsung.com> Reviewed-by:
Dave Thaler <dthaler@microsoft.com> Reviewed-by:
Ziran Sun <ziran.sun@samsung.com>
-
Jay Sharma authored
Bug : https://jira.iotivity.org/browse/IOT-2141 Change-Id: I6a77b388b401d9ee5364e9de2859e1c91978fca5 Signed-off-by:
Jay Sharma <jay.sharma@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19447Tested-by:
-
Sushil Yadav authored
Assuming that a remote server will always send a string larger than CA_MSG_ARBITER_DI_URI_LENGTH is wrong. A length check before indexing should fix the issue. Fixed issue: https://jira.iotivity.org/browse/IOT-2109 Change-Id: I63b2584acfa250569957e369fe0415f824052585 Signed-off-by:
Sushil Yadav <sushil.ky@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19437Reviewed-by:
-
abitha.s authored
Change-Id: I665727fffac64ac7635d4a5855a2f2b6462bb377 Signed-off-by:
abitha.s <abitha.s@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19529Tested-by:
-
- 02 May, 2017 16 commits
-
-
Todd Malsbary authored
Bug: https://jira.iotivity.org/browse/IOT-2128 Change-Id: Ie4532842d687a69b25d8f215135edeb2fd2029c6 Signed-off-by:
Todd Malsbary <todd.malsbary@intel.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19343Tested-by:
-
Nathan Heldt-Sheller authored
This reverts commit 819b3fe1. Change-Id: I0dc38a639f6d9558a0b41df8eb42c41e09adca11 Signed-off-by:
Alex Kelley <alexke@microsoft.com>
-
George Nash authoredBug: https://jira.iotivity.org/browse/IOT-2184 Change-Id: Iea34fa38db79da58f7245ea24ed5d85e26cf68c8 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19511Tested-by: Larry Sachs <larry.j.sachs@intel.com> Reviewed-by:
Thiago Moura <thiagogcm@gmail.com> Reviewed-by:
Rick Bell <richard.s.bell@intel.com>
-
Todd Malsbary authored
Problem was observed while building with RD_MODE and gcc-6.3. g++ \ -o out/linux/x86_64/release/resource/csdk/connectivity/test/catests \ (...) /bin/ld: \ out/linux/x86_64/release/liboctbstack_internal.a(oicresourcedirectory.o): \ undefined reference to symbol 'sqlite3_close' Change-Id: I6f0a3588cd816fd186db25df92b4b79db0bae6a5 Signed-off-by:
-
Dmitriy Zhuravlev authored
Server should be able to load PSK suite without discovery Change-Id: I957760b16325ac6b9f01c901f02cf6598e1aeb9e Signed-off-by:
Dmitriy Zhuravlev <d.zhuravlev@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19369Tested-by:
Andrii Shtompel <a.shtompel@samsung.com> Reviewed-by:
Oleksii Beketov <ol.beketov@samsung.com> Reviewed-by:
Greg Zaverucha <gregz@microsoft.com> Reviewed-by:
-
Dan Mihai authored
Windows currently has several different copies of connectivity_abstraction code and data in a single process. Other platforms are using a single copy of shared library connectivity_abstraction, in each process/app. It's better to avoid differences across platforms, because otherwise changes tested on one platform might not work on the other platforms. Linker behavior unchanged by this patch: ---------------------------------------- 1. On non-Windows platforms: IoTivity sample apps, and apps outside IoTivity, continue to link with connectivity_abstraction. 2. On Windows: IoTivity sample apps, and apps outside IoTivity, continue to link with octbstack.lib. Linker behavior changed by this patch: ---------------------------------------- 1. On all platforms: IoTivity-internal tests link with the static LIB connectivity_abstraction_internal. 2. On Windows: IoTivity sample apps, and apps outside IoTivity, no longer link directly with connectivity_abstraction.lib. They obtain access to connectivity_abstraction APIs by linking with octbstack.lib. 3. On Windows: Octbstack.dll links with the static LIB connectivity_abstraction_internal, and exports public connectivity_abstraction APIs. Change-Id: I48667d08d5be48e828800da2807c030753beab16 Signed-off-by:
-
Ziran Sun authored
When a OCF client connects to an OIC server with VND_CBOR format, it will be rejected. The client should reissue the request using OIC cbor format and does this automatically in the stack. Bug: https://jira.iotivity.org/browse/IOT-2120 Change-Id: I393283cefc8307c5eceb861a9b97375604dff53b Signed-off-by:
-
Nathan Heldt-Sheller authored
OCF 1.0 Security Spec requires Servers to expose only /oic/sec/acl2, and not /oic/sec/acl. Change-Id: I86550d160421f76bd89c72ee31864f029a83212b Signed-off-by:
-
Harry authored
Change-Id: Ic0e754afd3bfef91fa4340a6536b84303de47022 Signed-off-by:
Harry <h.marappa@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19043Tested-by:
Senthil Kumar G S <senthil.gs@samsung.com> Reviewed-by:
-
KIM JungYong authored
When valgrind of notification service(including cpp wrapper) is run, several leak was detected. (memory leak and invalid use of memory) in this patch, result of valgrind was fixed. 1. invalid use of string in the unit test code, was fixed. 2. when returnning with error, allocated memory was freed. 3. unfreed variable was freed. 4. unit test build warning was fixed. Change-Id: I4c8367bfda86813bb1ce1c71cf7841067c489ccc Signed-off-by:
KIM JungYong <jyong2.kim@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19009Tested-by:
-
KIM JungYong authored
getCachedAttribute API can throw exceptions, but RE linux sample does not handle for exception. In this patch, Exception is caught in the RE linux sample. Change-Id: I8b049835ec64e2929312c61d270bc54525a18b74 Signed-off-by:
-
Nathan Heldt-Sheller authored
Previously, a null return from FindResourceByUri() may have resulted in Unsecure Channel CREATE access to an OC_SECURE resource. Until the Policy Engine is updated to comprehend conntype access this hole should be closed. Change-Id: I4dbba12b108b103704cc931b3f03ef096e2ffc48 Signed-off-by:
-
KIM JungYong authored
When discoveryResource API was called in the RE layer, used invalid uri as empty resource type like "uri?rt=". In this patch, if resource type is empty, rt query is removed. Bug:https://jira.iotivity.org/browse/IOT-2139 Change-Id: I1e8d0c20bee661a822f977987742e2f10455af25 Signed-off-by:
-
Philippe Coval authored
Change-Id: I390887ac1585a170a023672a4f35e3f40631afe2 Signed-off-by:
-
KIM JungYong authored
NS provider sample has same input value for 2 different menu item. but there are for same functionality. so, in this patch this is fixed as two different menu item became one. Bug:https://jira.iotivity.org/browse/IOT-2152 Change-Id: I5d0b57addefc28e43ed09c57cc51bfa034cf92a4 Signed-off-by:
-
Jay Sharma authored
Bug: https://jira.iotivity.org/browse/IOT-2140 Change-Id: I80c0eb6a150c05bac61300b3885cda3ee7593dab Signed-off-by:
-
- 01 May, 2017 3 commits
-
-
Larry Sachs authored
Property name for spec version is incorrectly named 'lcv' it should be 'icv' Change-Id: Ic703857325a520fd8b30b4b8d0ef6a8b2c4e0c31 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-by: -
Dan Mihai authored
This file was using a combination of them. (Clean-up requested by reviewers of https://gerrit.iotivity.org/gerrit/#/c/18981/) Change-Id: Id1a8a0ae5f4f9bf718fc91c581ca46b865d26126 Signed-off-by:
-
Philippe Coval authored
This was discovered with clang on GNU/Linux Change-Id: Ia6ae233bb4aadc4165c0115d986b4588bcec7885 Signed-off-by:
Joseph Morrow <joseph.l.morrow@intel.com>
-
- 29 Apr, 2017 3 commits
-
-
Soemin Tjong authored
Change-Id: Ida29aa63931ace03f91aa1faeb05345645f8adb8 Signed-off-by:
-
Dan Mihai authored
IOT-1480 removed the IoTivity 1.2 call to this non-Public API. Change-Id: I6d688597b9049179beb227ce0f0e3219f15caf6a Signed-off-by:
-
Dan Mihai authored
Exporting these in IoTivity 1.2 was just due to the incipient procedure for building octbstack.dll. Change-Id: I13b066aeff2bd27a23c7b65c4bfb2a67efd049b0 Signed-off-by:
-
- 28 Apr, 2017 8 commits
-
-
Philippe Coval authored
Problem was observed while building with clang on GNU/Linux or gcc-6.3 clang++-3.5 \ -o out/linux/x86_64/release/resource/csdk/connectivity/test/catests \ (...) /usr/bin/ld: \ out/linux/x86_64/release/liboctbstack_internal.a(ocpayloadparse.o): \ undefined reference to symbol 'cbor_value_leave_container' liboctbstack.so: error adding symbols: DSO missing from command line Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: Icf8196858f46e5458e70b3e3bd6239ff0d4c688b Signed-off-by:
-
Dan Mihai authored
Add OCGetIpv6AddrScope, a thin wrapper over CAGetIpv6AddrScope. Change-Id: Idc573542c7a2b6103ff254399bd286515aa56d8e Signed-off-by:
-
Todd Malsbary authored
Problem was observed while building with SECURED=0 and gcc-6.3 g++ \ -o out/linux/x86_64/release/resource/csdk/connectivity/test/catests \ (...) /bin/ld: \ out/linux/x86_64/release/libc_common.a(oic_platform.o): \ undefined reference to symbol 'mbedtls_md_info_from_type' liboctbstack.so: error adding symbols: DSO missing from command line Change-Id: I46fc1f4cb7597b3396cb1bc29889db5ba9828d57 Signed-off-by:
-
C.J. Collier authored
Raise error on failure of "build" Raise error on failure of "test" Raise error on invalid target specification Change-Id: Icbcaaa8d3b3541ecdce640632b6fdeff9df4b142 Signed-off-by:
C.J. Collier <cjcollier@linuxfoundation.org> Signed-off-by:
Pawel Winogrodzki <pawelwi@microsoft.com> Reviewed-by:
Omar Maabreh <omarm@microsoft.com> Reviewed-by:
Way Vadhanasin <wayvad@microsoft.com>
-
Philippe Coval authored
Issue was reported using clang-3.5: resource/IPCA/src/inc/callback.h:39:7: error: forward declaration of class cannot have a nested name specifier class OC::OCResource; Change-Id: I1dd8c37a116b7f281aecb3f1c24700af69bf2b88 Signed-off-by:
-
Philippe Coval authored
Observed issue using clang on GNU/Linux: bridging/common/pluginServer.cpp:211:14:\ error: comparison of array 'ctx->reconnect_file_name' \ not equal to a null pointer is always true \ [-Werror,-Wtautological-pointer-compare] if (ctx->reconnect_file_name != NULL) Change-Id: Ifc5e40ba8d7943ca648e93627ed77cbc25f2731a Signed-off-by:
-
Todd Malsbary authored
This only applies to the application/vnd.ocf+cbor content format. - Response type is array, not object. - "di" is not part of baseline properties. Bug: https://jira.iotivity.org/browse/IOT-2056 Change-Id: I27a890509e888e82879afe87801249dc13c1c862 Signed-off-by:
Mushfiqul Islam <i.mushfiq@samsung.com> Reviewed-by:
-
Todd Malsbary authored
Also, don't publish IP eps with port of 0. Bug: https://jira.iotivity.org/browse/IOT-2063 Change-Id: I6c06c84a77ee8bbf3fa1c66ede8cdf776d2c1981 Signed-off-by:
byonggon chun <bg.chun@samsung.com> Reviewed-by:
-
- 27 Apr, 2017 2 commits
-
-
vijendrx authored
Replacing fgets/fputs with fstream equivalents and using std::string in nest_plugin, wherever applicable. Change-Id: I5c54556876cc09d1816672a1c30d641856b1c1c7 Signed-off-by:
vijendrx <vijendrax.kumar@intel.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17579Reviewed-by:
-
vijendrx authored
Replacing fgets/fputs with fstream equivalents and using std::string in lifx_plugin, wherever applicable. Change-Id: I53d4dfe021e5271a7ccc05a9959d162fde4fede0 Signed-off-by:
-
