- 14 Aug, 2017 2 commits
-
-
Philippe Coval authored
Functions in payload_logging.h can be used in examples, so it's installed in "experimental" sub namespace along dependencies. Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: If3a9e4309601c356ab9a2faaa9fbe26283408633 Signed-off-by:
Philippe Coval <philippe.coval@osg.samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/21195Tested-by:
jenkins-iotivity <jenkins@iotivity.org> Reviewed-by:
George Nash <george.nash@intel.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
-
Sangjoon Je authored
Add pstat add remove modify Cleanup svrdbeditoracl.c New Feature: https://jira.iotivity.org/browse/IOT-2494Signed-off-by:
Sangjoon Je <sangjoon.je@samsung.com> Change-Id: I851e8555f5a1d14332399f0c9aedc53bfa302bb3 Reviewed-on: https://gerrit.iotivity.org/gerrit/21799Tested-by:
Jongmin Choi <jminl.choi@samsung.com> Reviewed-by:
Youngman Jung <yman.jung@samsung.com> Reviewed-by:
Randeep Singh <randeep.s@samsung.com>
-
- 12 Aug, 2017 3 commits
-
-
Philippe Coval authored
CBOR.dat files are generated using json2cbor tool at build time. If not possible they are just copied. Bug: https://jira.iotivity.org/browse/IOT-2310 Change-Id: Ic55f01284934aa0415f8f7cdea78c40fa8aaa459 Origin: https://gerrit.iotivity.org/gerrit/#/c/21087/Signed-off-by:
George Nash <george.nash@intel.com>
Tested-by: -
George Nash authoredIt is common to do a compair with a const value in unit tests. For example EXPECT_EQ(3, value). If `value` is an unsigned type this will produce the sign-compare compiler warning. The compiler defaults to treating constant numbers as a signed data type. Adding a sufix u (i.e. 3u) will tell the compiler to treat the constant as an unsigned data type. In other cases the type is cast to an unsigned or signed value before the comparison. In aclresourcetest.cpp the return type for GetNumberOfResource function was updated to return size_t since in all the test conditions it is compared with variable of size_t or a constant number. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I7e47bfb9f027304abd975eb0d8e577cbd484545a Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21689Tested-by: -
Philippe Coval authored
As not supported on clang-3.5 Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: I7bb4f53a0a0e2eba56e670f87ac163a211173fb6 Signed-off-by:
George Nash <george.nash@intel.com>
Tested-by:
-
- 11 Aug, 2017 11 commits
-
-
George Nash authored
pmutility.c code would give an implicit-funtion-declaration warning when the usleep function was used. On linux the usleep function is part of unistd.h which was already included. usleep is not exposed unless _DEFAULT_SOURCE or _BSD_SOURCE is defined before including unistd.h. To prevent another warning [-Wcpp] both macros are included. As directed in the glibc release notes: https://sourceware.org/glibc/wiki/Release/2.20#Packaging_Changes Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I7002ef303ba685bda76f70590d7c9593435b4ba7 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21707Tested-by: -
Philippe Coval authored
CBOR files (.dat) are generated using json2cbor tool at build time. If not possible they are just copied. Bug: https://jira.iotivity.org/browse/IOT-2310 Change-Id: I9ec2e6661252ea73c6b6c81ec399b4c7ee731984 Origin: https://gerrit.iotivity.org/gerrit/#/c/21085/Signed-off-by:
George Nash <george.nash@intel.com>
Tested-by: -
George Nash authored
This is a set of code that will sometimes have a warning depending on what is defined. To prevent the unused-parameter warning the parameters are cast to void. A empty operation that will be compiled out but prevents the warning. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I08c73fb565b62d3a760956976a012331863a6c73 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21769Tested-by: -
George Nash authored
The write-strings warning comes from assigning the a const string to a char* that is not const. From everything I see in this example the string is not changed so simply using const_cast will remove the warning. If these values are always expected to be constant we may want to consider changing the strutures to hold const char * not char *. Without further investigation I did not feel safe making that change. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: Ib9053a1041b72b1fd05329999efc7a7ff28aab94 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21753Tested-by: Mats Wichmann <mats@linux.com> Reviewed-by:
Rick Bell <richard.s.bell@intel.com>
-
George Nash authored
The -Wformat= warning is given when the conversion specifier in a printf or scanf command does not match the value actually passed in. In this commit all of the issues are found in LOG functions. If type passed in was a variable size parameter like a pointer or size_t. The the PRIuPTR value from the inttypes.h header is used. For ssize_t variables the PRIdPTR was used. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I4977253ac7ee68d2e80a26a0963b770b2ce87032 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21771Tested-by: -
George Nash authored
The static function GenerateEccKeyPair in occertutility.c in unused and can be delete. Note: there is a line for line copy of this function also found in certhelpers.c that is used. So deleting this function will not cause the code to be lost. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I3a5aefdd316cf5cedd6af58811358ebdd3589838 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21735Tested-by: -
George Nash authored
Wrap the files that are generated using the gdbus-codegen tool with the GCC diagnostic ignore -Wunused-parameter pragma to prevent this code producing the unused-parameter warning. If transports was set to ALL the build script was calling build for all of the connectivity transports twice. This caused SCons to print a warning that two builds were specifying the same build target. To fix the extra unneeded call to the build script was removed. Bug: https://jira.iotivity.org/browse/IOT-2542 Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I997506b43099425718a7f04f9c66be49a49dc717 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21641Tested-by: -
George Nash authored
The pdu.c file was producing an implicit-function-declaration warning for the ntohs() function. The ntohs function is part of the arpa/inet.h header. This is conditionally included based on the HAVE_ARPA_INET_H macro. The HAVE_ARPA_INET_H macro is defined in the iotivity_config.h header. So iotivity_config.h must be included in pdu.c to properly detect the macro. It looks like some systems may supply the ntohs() function without arpa/inet.h. So it is unclear if the call to the function its self needs some added macros. Change-Id: I7e19d65e1371d46b35d70a5ecdf06fb0b73152ff Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21683Tested-by: -
George Nash authored
This warning comes from teh glibc library. The library has a # warning in the code if _BSD_SOURCE or _SVID_SOURCE are defined in the code. The code that was enabled using the two macros has been depricated. The new _DEFAULT_SOURCE macro should be used to enable the features that were enabled by the old macros. If you need to build with old and newer versions of glibc the glibc release notes recomend using both the old and new macros. see: https://sourceware.org/glibc/wiki/Release/2.20#Packaging_Changes Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I000d3bbfe4fdc473066d8c50862070c8b49788ca Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21655Tested-by: -
Veeraj Khokale authored
1. Modify tizen BLE server to use the 3.0 API's. 2. Add unicast send logic to tizen BLE client 3. Add tizen 3.0 profile to gbs build and use it as the default profile for BLE transport Change-Id: I527d71adf1daf9142353e87fbb6ff59a9cdae935 Signed-off-by:
Veeraj Khokale <veeraj.sk@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/13459Tested-by:
Ashok Babu Channa <ashok.channa@samsung.com>
-
Philippe Coval authored
Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: I77d8f514e88d8157b1d5948b76d63519fa2957b4 Signed-off-by:
-
- 10 Aug, 2017 4 commits
-
-
Philippe Coval authored
Bug: https://jira.iotivity.org/browse/IOT-1760 Change-Id: Icb301bb46ca5faab46576deea35ac623646a1ade Signed-off-by:
-
Philippe Coval authored
Relate-to: https://gerrit.iotivity.org/gerrit/21713 https://gerrit.iotivity.org/gerrit/21601 https://gerrit.iotivity.org/gerrit/21621 https://gerrit.iotivity.org/gerrit/21741 https://gerrit.iotivity.org/gerrit/17411 https://gerrit.iotivity.org/gerrit/21555 Change-Id: I0d609e16 Bug: https://jira.iotivity.org/browse/IOT-2453Signed-off-by:
-
Alex Kelley authored
Change-Id: If6aead88b0958237df73da77c41123755c7e4ee9 Signed-off-by:
Alex Kelley <alexke@microsoft.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/21713Tested-by:
-
Todd Malsbary authored
Bug: https://jira.iotivity.org/browse/IOT-2536 Change-Id: Ib3760af5db55bfb464daf692100e8731a7d52092 Signed-off-by:
Todd Malsbary <todd.malsbary@intel.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/21601Tested-by:
-
- 09 Aug, 2017 13 commits
-
-
Philippe Coval authored
Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: Id528461dcc6c07551554a07def899f612df97be6 Signed-off-by:
-
George Nash authored
On linux pthread_t is not a pointer type so assigning it as NULL is an error. pthread_t should be assigned using the functions like pthread_create which is already done. Change-Id: I55559a3ed3d4de82dd4863b1ee6e0ce11dd1726b Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21739Tested-by: Abhishek Pandey <abhi.siso@samsung.com> Reviewed-by:
-
George Nash authored
The CompareCredential function is unused. Any code that is unused is not maintained. This removes the unused function. If the CompareCredential is needed in the future it can be restored by reverting this commit. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: Ib5c1fee9a2bd90db3b55066a6e3b057760199b68 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21747Tested-by: Kevin Kane <kkane@microsoft.com> Reviewed-by:
-
George Nash authored
The sscanf was using %lu flag that is a long unsigned int while passing in a uint32_t value which is an unsigned int This changes the flag from %lu to %u to clean the format warning. Change-Id: Iba1d10e2b2403fa5adb94650764ee04c290c951b Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21701Tested-by: Dave Thaler <dthaler@microsoft.com> Reviewed-by:
-
George Nash authored
The _worker function expects a void * return type only functions with return type of void do not have to have a return. Since the return value does not appear to be used simply return NULL. Change-Id: I3cee6f7a491320d21b1d70f9a8df0f7b4538087b Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21737Tested-by: -
George Nash authored
g_MotCtx is not used anywhere in the code and can be removed. Change-Id: I382c16b26a0aafac366f47a1fb01c3b13b1fdb4a Bus: https://jira.iotivity.org/browse/IOT-2539Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21709Tested-by: -
Gerrit Code Review authored
-
Alex Kelley authored
Update OCClient and OCServer to support ownership transfer. Change-Id: Iab48685ca4fe6a8b19d6b8cba597a5e25833a7d4 Signed-off-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
Alex Kelley authored
This change updates ProvisioningClient's waitCallbackRet to return -1 if it times out waiting for a callback to indicate the operation has finished. Change-Id: I904e41fa7fc5fbed73344b08c30c45235678b646 Signed-off-by:
-
Philippe Coval authored
Change-Id: Ie070f4d01c9a665373221d6924453b7da50cfa4f Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com> (cherry picked from commit 4f456acd) Reviewed-on: https://gerrit.iotivity.org/gerrit/21555Reviewed-by:
Joseph Morrow <joseph.l.morrow@intel.com> Reviewed-by:
-
Philippe Coval authored
By the way JSON files are also converted to use unix EOL Note: those files may need to be updated to support current ACL (and commited by security team, check status of json and dat files) Bug: https://jira.iotivity.org/browse/IOT-2310 Change-Id: If6e0c1d29c53556a57d31ced1224ae75eeb0c9c1 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-by: -
Philippe Coval authored
Relate-to: https://gerrit.iotivity.org/gerrit/21613 https://gerrit.iotivity.org/gerrit/20475 https://gerrit.iotivity.org/gerrit/21629 https://gerrit.iotivity.org/gerrit/21669 Change-Id: I73b7fa38 Bug: https://jira.iotivity.org/browse/IOT-2453Signed-off-by:
-
Aleksey authored
Change-Id: I456a0d09266561c7b6d6f6912e234aac2ca550c0 Signed-off-by:
Aleksey Volkov <a.volkov@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/21613Tested-by:
-
- 08 Aug, 2017 6 commits
-
-
Dmitriy Zhuravlev authored
CATCPPacketSendCB changed to synchronous completion Change-Id: I4ed43d5c580ba4beee510d0e0475481c57e571c6 Signed-off-by:
Dmitriy Zhuravlev <d.zhuravlev@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/20847Tested-by:
-
Dmitriy Zhuravlev authored
CATCPPacketSendCB changed to synchronous completion Change-Id: I4ed43d5c580ba4beee510d0e0475481c57e571c6 Signed-off-by:
Way Vadhanasin <wayvad@microsoft.com> Reviewed-by:
-
Sangjoon Je authored
Print info for ACL_V2 Support Modify ACL Split svrdbeditor.c into several files Fix svace issue Fix valgrind mem leak issue Fix wrong error msg New Feature: https://jira.iotivity.org/browse/IOT-2494 Change-Id: I02636ed59e293108a4e5cf6bf7e75a19dafeb455 Signed-off-by:
-
George Nash authored
Used the OC_UNUSED macro for unused parameters in callback functions. Deleted unused variables. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I5b1ad8bb52622217fc3a4ab11ff18b3e8f1376d9 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21757Tested-by: -
uzchoi authored
Previously OCPayloadConvert logic in sever side only convert uri, types and interfaces for the top level element. Even if a RepPayload exists in the RepPayload, uri and so on are not converted. This patch move the uri, type and interface convert logic into OCConvertSingleRepPayload which is recrsively called function. Previous code skipped to convert href in case array payload size is 1 on the top level payload. This logic should be removed at least considering collection resource with linked-list interface request. Furthermore, this skip logic is not mandatory code for certification as of now. Change-Id: I17b1cc02aed37e9af55126d3af2d28310a3ae733 Signed-off-by:
uzchoi <uzchoi@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/21629Tested-by:
-
v.riznyk authored
Change-Id: If5543c617c3f40193604349ea42df82be5645055 Signed-off-by:
v.riznyk <v.riznyk@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/21669Tested-by:
-
- 06 Aug, 2017 1 commit
-
-
Philippe Coval authored
Relate-to: https://gerrit.iotivity.org/gerrit/21461 https://gerrit.iotivity.org/gerrit/21425 https://gerrit.iotivity.org/gerrit/21465 https://gerrit.iotivity.org/gerrit/21733 Change-Id: I96293bfd Bug: https://jira.iotivity.org/browse/IOT-2453Signed-off-by:
-
