1. 17 Mar, 2018 1 commit
  2. 16 Mar, 2018 3 commits
  3. 15 Mar, 2018 1 commit
    • Abhishek Pandey's avatar
      Easy Setup CoAPCloudConf Resource Update · 2c9df2de
      Abhishek Pandey authored
      IOT-2963: https://jira.iotivity.org/browse/IOT-2963
      
      In the upcoming version of OCF Spec, there are some changes in
      definition of CoAPCloudConf Resource (oic.r.coapcloudconf). This patch
      is for aligning the same with IoTivity implementation.
      
      Following changes are done in this patch:
      
      1) [Enrollee] Removed setting of Access Token Type (att) in GET
      Response Payload.
      2) [Enrollee] Removed reading of Access Token Type (att) from POST
      Request Payload and passing a default value of "Bearer" to application.
      3) [Enrollee] Removed Auth code Property from Enrollee. (this shouldn't
      cause any harm).
      4) [Mediator] Deprecated Getter and Setter APIs for Auth Code and
      Access Token Type from Mediator
      
      Change-Id: I6997b9e1b13cb9cd8bf95777e9984e4a749c87dd
      Signed-off-by: default avatarAbhishek Pandey <abhi.siso@samsung.com>
      2c9df2de
  4. 14 Mar, 2018 2 commits
  5. 12 Mar, 2018 1 commit
  6. 11 Mar, 2018 1 commit
  7. 09 Mar, 2018 2 commits
  8. 08 Mar, 2018 1 commit
  9. 07 Mar, 2018 3 commits
  10. 06 Mar, 2018 6 commits
    • Philippe Coval's avatar
      notification: Sync JSON and CBOR files · 54075fb9
      Philippe Coval authored
      File is updated after running test.
      
      To avoid local changes on build,
      let's commit the updated .dat files (using json2cbor),
      
      Reminding, It's developer dutty to commit those files on each changes
      on json source or any change that produce a different result.
      This way we're not leaving inconsistant binary files in tree.
      
      JSON file was not modified because it is already in UNIX format
      
      Note: those files may need to be updated to support current ACL
      (and commited by security team, check status of json and dat files)
      
      Bug: https://jira.iotivity.org/browse/IOT-2310
      Change-Id: I874c14c46c229ff9d0aee56000bd9c4f68786090
      Signed-off-by: default avatarPhilippe Coval <philippe.coval@osg.samsung.com>
      54075fb9
    • Philippe Coval's avatar
      examples: Sync JSON and CBOR files · eeff74c9
      Philippe Coval authored
      File is updated after running test.
      
      To avoid local changes on build,
      let's commit the updated .dat files (using json2cbor),
      
      Reminding, It's developer dutty to commit those files on each changes
      on json source or any change that produce a different result.
      This way we're not leaving inconsistant binary files in tree.
      
      JSON file was not modified because it is already in UNIX format
      
      Note: those files may need to be updated to support current ACL
      (and commited by security team, check status of json and dat files)
      
      Bug: https://jira.iotivity.org/browse/IOT-2310
      Change-Id: If8212a54393b74110e6804847b8acaac4c2dce7c
      Signed-off-by: default avatarPhilippe Coval <philippe.coval@osg.samsung.com>
      eeff74c9
    • Philippe Coval's avatar
      IPCA: Sync JSON and CBOR files · 366d4927
      Philippe Coval authored
      File is updated after running test.
      
      To avoid local changes on build,
      let's commit the updated .dat files (using json2cbor),
      
      Reminding, It's developer dutty to commit those files on each changes
      on json source or any change that produce a different result.
      This way we're not leaving inconsistant binary files in tree.
      
      JSON file was not modified because it is already in UNIX format
      
      Note: those files may need to be updated to support current ACL
      (and commited by security team, check status of json and dat files)
      
      Bug: https://jira.iotivity.org/browse/IOT-2310
      Change-Id: I6570f84ea66652b3cbab7d5182e23cb4d087dbff
      Origin: https://gerrit.iotivity.org/gerrit/#/c/22001/Signed-off-by: default avatarPhilippe Coval <philippe.coval@osg.samsung.com>
      366d4927
    • Philippe Coval's avatar
      coap-http-proxy: Sync JSON and CBOR files · f986ee4a
      Philippe Coval authored
      File is updated after running test.
      
      To avoid local changes on build,
      let's commit the updated .dat files (using json2cbor),
      
      Reminding, It's developer dutty to commit those files on each changes
      on json source or any change that produce a different result.
      This way we're not leaving inconsistant binary files in tree.
      
      JSON file was not modified because it is already in UNIX format
      
      Note: those files may need to be updated to support current ACL
      (and commited by security team, check status of json and dat files)
      
      Bug: https://jira.iotivity.org/browse/IOT-2310
      Change-Id: I07a7482eab8eef04c26604e0113020d5c62603a1
      Signed-off-by: default avatarPhilippe Coval <philippe.coval@osg.samsung.com>
      f986ee4a
    • Philippe Coval's avatar
      csdk: Sync JSON and CBOR files · 3d9e12dd
      Philippe Coval authored
      File is updated after running test.
      
      To avoid local changes on build,
      let's commit the updated .dat files (using json2cbor),
      
      Reminding, It's developer dutty to commit those files on each changes
      on json source or any change that produce a different result.
      This way we're not leaving inconsistant binary files in tree.
      
      JSON file was not modified because it is already in UNIX format
      
      Note: those files may need to be updated to support current ACL
      (and commited by security team, check status of json and dat files)
      
      Bug: https://jira.iotivity.org/browse/IOT-2310
      Change-Id: I5ef7105eacf52f3c0e5b79fc1a3da77c987ec601
      Signed-off-by: default avatarPhilippe Coval <philippe.coval@osg.samsung.com>
      3d9e12dd
    • Martin Roesch's avatar
      [IOT-2019] Add missing mutex include. · 264b3e46
      Martin Roesch authored
      When compiling IoTivity with WITH_CLOUD=true WITH_MQ=PUB,SUB
      the aircon_controlee example fails to compile:
      In file included from cloud/samples/client/airconditioner/aircon_controlee.cpp:12:0:
      resource/csdk/resource-directory/include/RDClient.h:49:21: error: 'recursive_mutex' is not a member of 'std'
           std::shared_ptr<std::recursive_mutex> _csdkLock;
      
      Including the mutex header fixes the issue.
      
      Change-Id: I1aa4a7fcc5b66ea05382dc3a821598abf5a91c0b
      Signed-off-by: default avatarMartin Roesch <martin.roesch@kistler.com>
      264b3e46
  11. 05 Mar, 2018 1 commit
  12. 02 Mar, 2018 3 commits
  13. 01 Mar, 2018 3 commits
  14. 28 Feb, 2018 1 commit
  15. 26 Feb, 2018 1 commit
    • uzchoi's avatar
      [IOT-2762] CreateEndpoint err in secured mode · 1e78108a
      uzchoi authored
      In case of server process and client process exist in a same machine,
      ifindex of CAEndpoint_t is different from the ifindex of Request DevAddr
      because the ifindex of request DevAddr indicate local loopback in 
      secured mode while CAEndpoint_t shows physical interface.
      This error can be fixed by checking whether the sender is from loopback.
      However, some machine shows wrong print in if_indextoname() such as 
      eth0 instead of lo.
      For this reason, I removed the comparison of ifindex. For more exact 
      check, we can put IP address is from my machine but looks inefficient.
      
      Change-Id: Ic67fd2b4609df5779cb2775f632dca79b2bc7232
      Signed-off-by: default avataruzchoi <uzchoi@samsung.com>
      1e78108a
  16. 24 Feb, 2018 1 commit
    • Mats Wichmann's avatar
      MLK: Clean 5 stack unittest valgrind leak reports · 17f67a73
      Mats Wichmann authored
      These are in the test code only.
      
      1/2. The test TEST(LinksPayloadArray, BuildCollectionLinksPayloadArray)
      has multiple allocations that are not freed.
      
        736 bytes in 1 blocks are definitely lost in loss record 962 of 988
        alloc ~3019:  CAGetNetworkInformation(&info, &size);
        added OICFree(info); at function end
      
        184 bytes in 1 blocks are definitely lost in loss record 922 of 988
        allocated ~3015: OCDevAddr* devAddr = (OCDevAddr*)OICCalloc(1, sizeof(OCDevAddr));
        added OICFree(devAddr); at function end
      
      3. Still in TEST(LinksPayloadArray, BuildCollectionLinksPayloadArray),
        134 bytes in 4 blocks are definitely lost in loss record 901 of 988
        alloc ~3125:   ASSERT_TRUE(OCRepPayloadGetPropString(epsMap[k], OC_RSRVD_ENDPOINT, &outUri));
        outUri is allocated, tested, not freed.
      
        Added an OICFree at the end of the loop
      
      4/5. two calls to OCRepPayloadGetPropObject happen in a pair of loops;
      freeing is outside the loops which means that iterations other than
      the last have their allocation lost, not freed.
      
        252 (48 direct, 204 indirect) bytes in 1 blocks are definitely lost in loss record 929 of 988
        115 (48 direct, 67 indirect) bytes in 1 blocks are definitely lost in loss record 892 of 988
      
      Note for reviewers: some other leak reports for this
      unittest were traced to flaws in the stack code, and
      were split off into separate commits as a result, since
      "approve change to stack" might be quite different than
      "approve change to unittest".  See:
      https://gerrit.iotivity.org/gerrit/23847
      https://gerrit.iotivity.org/gerrit/23849
      
      With the items in this change and the two referenced change,
      the 12 "definitely lost" leak reports for the stack
      unittest are reduced to two.
      
      Change-Id: I6f1c74eedc6e9be40173bde8c1f321e84dbc83f0
      Signed-off-by: default avatarMats Wichmann <mats@linux.com>
      17f67a73
  17. 23 Feb, 2018 1 commit
  18. 17 Feb, 2018 2 commits
    • Philippe Coval's avatar
      notification: Declare strict void function · 22b80006
      Philippe Coval authored
      Declare void functions as strict prototype
      
      If built along -Wstrict-prototypes it will raise and error,
      this is the case on TizenRT.
      
      More patches to come to enable this flag by default.
      
      Bug: https://jira.iotivity.org/browse/IOT-2539
      Change-Id: I7740d360a34dc114cf205fdf3a366ea1537c6f9f
      Origin: https://gerrit.iotivity.org/gerrit/#/c/23865/Signed-off-by: default avatarPhilippe Coval <philippe.coval@osg.samsung.com>
      22b80006
    • George Nash's avatar
      [IOT-2972] Extend linux error-on-warn to C++ · 2fd7ba30
      George Nash authored
      -Werror, which causes warnings to be treated as errors,
      is set in Linux build in CFLAGS, which applies only to
      C builds. This moves the -Werror to CCFLAGS so it applies
      to both C and C++.
      
      This also fixes build warnings in C++ code a the same time.
      
      OICMiddle/Server.cpp [-Werror=int-in-bool-context]
      The logic `&&` was used when `&` should have been used in
      the if statment
      
      OCResource.cpp [-Werror=int-in-bool-context]
      An enum constant was in a bool context. This was using
      different logic if security was enabled vs. when it was
      not enabled. The code was changed to use preprocessor
      macros instead of the value of OC_SECURED in an if statment.
      
      NSProvider.h and NSProvider.cpp: [-Werror=deprecated]
      Throw expresions have been deprecated since C++11. They
      were replaced with `nothrow`.
      
      See: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2010/n3051.html
      
      Since IoTivity's C++ implementation must support C++11
      no effort has been made to keep the code backwards compatible
      with compilers that do not support the `nothrow` keyword.
      
      CoapHttpParser.c: [-Werror]
      This is generated from the Curl code.
      When the `CURLINFO_PRIVATE` option is used with the
      `curl_easy_getinfo` function the expected argument type is `char **`.
      The documentation says it is used like a `void **` but for historic
      reasons a `char **` is expected.
      
      To fix the warning a simple type cast is used.
      
      Change-Id: Ia24e1c6df01d39923cbfb6705d0dc0af7d4f3870
      Signed-off-by: George Nash's avatarGeorge Nash <george.nash@intel.com>
      2fd7ba30
  19. 15 Feb, 2018 1 commit
  20. 14 Feb, 2018 1 commit
  21. 13 Feb, 2018 2 commits
  22. 12 Feb, 2018 1 commit
  23. 09 Feb, 2018 1 commit