- 23 Mar, 2017 1 commit
-
-
Kevin Kane authored
Change cred resource to always provide own certificate as a PEM string, and no longer require ParseChain to heuristically parse a mixed bag of DER and PEM certs. Also, go back to having ParseChain return an int rather than a size_t which was changed during /W4 warning cleanup; it must be able to return negative values to indicate errors. Change-Id: Id36962ed580eb3bccc110aac0350349b05674ee7 Signed-off-by:
Kevin Kane <kkane@microsoft.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17835Tested-by:
jenkins-iotivity <jenkins@iotivity.org> Reviewed-by:
Alex Kelley <alexke@microsoft.com> Reviewed-by:
Greg Zaverucha <gregz@microsoft.com>
-
- 22 Mar, 2017 2 commits
-
-
Kevin Kane authored
Change-Id: If30ba205d4fcb0b5dc969f83d464509a8059ef3f Signed-off-by: -
Kevin Kane authored
Remove fetching of subjectCborType into its own variable, which ends up being unused if LOGGING is not defined and causes a warning that breaks the build; instead, fetch the value as part of the logging call so it also gets compiled out if LOGGING is not defined. Change-Id: Iee950abe0d7c160d2feb50138df5fe39c69addf4 Signed-off-by:
Way Vadhanasin <wayvad@microsoft.com> Reviewed-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
- 21 Mar, 2017 2 commits
-
-
Philippe Coval authored
Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: I74ab383626672ec37287514b37826b23135b2f64 Signed-off-by:
Philippe Coval <philippe.coval@osg.samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17857Tested-by:
Mats Wichmann <mats@linux.com> Reviewed-by:
Ashok Babu Channa <ashok.channa@samsung.com>
-
Parkhi authored
https://gerrit.iotivity.org/gerrit/#/c/17995/ - ThrowExceptionWhenProvisionDeviceProperiesFailedWithoutSSID Change-Id: I59058bdbf5e585979dae643d66279adc9886c65a Signed-off-by:
Parkhi <h_w.park@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/18037Reviewed-by:
Uze Choi <uzchoi@samsung.com> Tested-by:
-
- 20 Mar, 2017 8 commits
-
-
Craig Pratt authored
Added oic.sec.dpmtype bitfield definitions and pstat.tm change detection logic. Changed the SVR enum declarations to uints instead of enums to avoid C++ type conversion errors and enable bitfield operations on these fields. This was causing compilation errors on arduino builds when doing bitfield operations on pstat.tm/.cm. Change-Id: I31b07cc040a2d22296d6cd75897b69a0d06b5eb4 Author: Craig Pratt <craig@ecaspia.com> Signed-off-by:
Craig Pratt <craig@ecaspia.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17521Tested-by:
-
Poovizhi authored
[IOT-1880] Adding Fixes for issues generated from static analyzer tool in Notification service c++ , JNI layer 1) In JNINotificationConsumer.cpp, Getting native Provider object is common code for all the native methods. Added a separate method ' getNativeProvider' to do this, so that method size and complexity will be reduced. 2) JNiNotificationConsumer.cpp Line 1379, and NSTopicslist.cpp Line 59 has changes to fix the issue of Unreachable code. 3) Copy constructor and copy assignment operator are added in class 'NSAcceptedProviders' & 'NSAcceptedConsumers' which has dynamically allocated data members 4) In NSAcceptedProviders class, getProviders() method is changed to const since it is being used by the copy constructors and hence modified the member variable 'm_mutex' to be mutable. 5) In NSAcceptedConsumers class, getConsumers() method is changed to const since it is being used by the copy constructors and hence modified the member variable 'm_mutex' to be mutable. 6) In NotiListener.java, the NULL check for mProviderSample is moved above the first instance where mProviderSample is beig used. Change-Id: Ic18c3d9797a02a73f5397192b21e7dda5926119e Signed-off-by:
Poovizhi <poovizhi.a@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17653Reviewed-by:
-
Philippe Coval authored
This will prevent errors, like: /usr/include/iotivity/resource/octypes.h:32:27: \ fatal error: ocstackconfig.h: No such file or directory It was tested on Debian Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: I8a4f06cd05158e8659628a654dfdbe7e1784e4bc Signed-off-by:
-
jihwan.seo authored
Change-Id: I07b98f7bb0e89addf9fafa496aea78061085707d Signed-off-by:
jihwan.seo <jihwan.seo@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17935Tested-by:
Dan Mihai <Daniel.Mihai@microsoft.com> Reviewed-by:
-
Jihun Ha authored
There would be a case where user wants to provision only device configuration without any wifi configuration. In this case, a condition to filter a case of empty ssid should be removed. Change-Id: Ib135d40d7f59f1ef0ee1bf7fe24a5a54d737aa96 Signed-off-by:
Jihun Ha <jihun.ha@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17995Reviewed-by:
-
Poovizhi authored
Dependency of hippomocks is removed in notificaiton service Change-Id: I9705e2d92a4eec4addecb5a51893a7898d056867 Signed-off-by:
-
Jihun Ha authored
If an user does not set any MOT configuration and ownership transfer is successfully done, then a result should be ES_OK. If ESOwnershipTransferData->getMOTMethod() is OIC_OXM_COUNT, it means user does not set the configuration. Change-Id: I055beed8e893ae0754a4f5ea467cbe99f649ca4d Signed-off-by:
-
Parkhi authored
Change-Id: I63dbeed58bae6c943ce8374685bcdaea867ec57e Signed-off-by:
-
- 18 Mar, 2017 1 commit
-
-
Nathan Heldt-Sheller authored
Issue description: CTT sends requests over coap, but isRequestOverSecureChannel incorrectly concludes that these requests arrived over a secured channel. That's because here: if(memcmp(context->requestInfo->info.identity.id, nullSubjectId.id, sizeof(context->requestInfo->info.identity.id)) != 0) sizeof(context->requestInfo->info.identity.id) is larger than sizeof(nullSubjectId.id). So, that compares a bunch of random bytes from the stack with the bytes from context->requestInfo->info.identity.id. This changes logic to compare like-sized objects. patchset 2: resolved IOT-1849; created new IOT-1894 "Determine appropriate CA_MAX_ENDPOINT_IDENTITY_LEN" (see "TODO IOT-1894" comment). patchset 3: comment typo fix patchset 4: self review fixes patchset 5: addressed Dan's feedback patchset 6: addressed Phil's feedback patchset 7: replaced if( with if ( throughout Change-Id: I2781357c74a1e0c47a534bc6df2f2b790c0caae7 Signed-off-by:
-
- 17 Mar, 2017 3 commits
-
-
Kevin Kane authored
Only recompute roles for a peer when the list of certificates changes, or when one of the certificates expires. Change-Id: Ifb25af82fcaa412b46d7612f024deced667456b9 Signed-off-by:
Soemin Tjong <stjong@microsoft.com> Reviewed-by:
-
Kevin Kane authored
Previous solution used a temporary custom string format to differentiate UUID-based and role-based subjects. Change this to using a proper map inside the CBOR for a role, and differentiate based on whether the subject value is a text string (in which case it's a UUID type) or a map (in which case a role). Plug another couple memory leaks found along the way. Change-Id: Ic592d3538685c9a9ce664619099cfe2ac4889033 Signed-off-by:
Pawel Winogrodzki <pawelwi@microsoft.com> Reviewed-by:
-
Jihun Ha authored
Added error code: - ES_ERRCODE_UNSUPPORTED_WIFI_FREQUENCY = 13 - An Enrollee can not connect to a target WiFi AP because the AP resides in an unsupported WiFi frequency Change-Id: Ia233e0e5e0bf8bee6dfa4f4b8a0660be325b363f Signed-off-by:
-
- 16 Mar, 2017 5 commits
-
-
Pawel Winogrodzki authored
Fixing PMCloneOCProvisionDev to perform a proper deep copy of the internal doxm::subOwners and doxm::mom fields, so that they no longer point to the same structs as the original. Change-Id: I5b30e4e7012934b9a17a4f8d7cecd6d2b65b1055 Signed-off-by:
Mike Fenelon <mike.fenelon@microsoft.com> Reviewed-by:
-
Alex Kelley authored
Change-Id: Ifbcc174efebd666d05f4134974267142a01c9f5f Signed-off-by:
-
Philippe Coval authored
Change-Id: Ie8ef6699fc8a999579fe3e1e8474d3133a179ef9 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-by: -
Dan Mihai authored
Recent change d10c4a88 removed the writeable deviceuuid (a.k.a. OIC_JSON_DEVICE_ID_NAME) property. Change-Id: Iee4ca533c29a77461603a97fadc7ad2207a40411 Signed-off-by:
-
Harry authored
Change-Id: I9596008496042ca00890f93bc87f121bcbc7c7bd Signed-off-by:
Harry <h.marappa@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17613Tested-by:
Chihyun Cho <ch79.cho@samsung.com> Reviewed-by:
JungYong KIM <jyong2.kim@samsung.com> Reviewed-by:
Jaewook Jung <jw0213.jung@samsung.com> Reviewed-by:
Jaehong Jo <jaehong.jo@samsung.com> Reviewed-by:
Habib Virji <habib.virji@samsung.com> Reviewed-by:
-
- 15 Mar, 2017 3 commits
-
-
Kihyuck Shin authored
- OIC_TRACE_MARK, OIC_TRACE_BUFFER Add and modify trace point positions for clarification. Change-Id: I3996b38d71d3a2cfe4abff2353f8aef66e6ceb8a Signed-off-by:
Kihyuck Shin <kihyuck.shin@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17821Tested-by:
-
Zoltan Kuscsik authored
Fixing the issue when jar bundles are never gets loaded. Change-Id: I0e068f39b95434a21c1481244a79a444659aa430 Signed-off-by:
Zoltan Kuscsik <kuscsik@gmail.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17773Tested-by:
-
Zoltan Kuscsik authored
Added dummy implementations of deactivateResource for sample BundleResource Change-Id: I68527a2bad7f113164b9a631aca0608542fa9e09 Signed-off-by:
-
- 14 Mar, 2017 3 commits
-
-
Alex Kelley authored
These changes include the following: - Fix W4 warnings under resource/csdk/stack. - Fix W4 warnings under resource/csdk/stack/test. - Enable /W4 /WX on resource/csdk/stack. - Enable /W4 /WX on resource/csdk/stack/test. - Move disabling warnings from resource/csdk/security to build_common/Windows. Change-Id: Ifed02e4e339093e49b6d174dfe3e3d52469f24ac Signed-off-by:
George Nash <george.nash@intel.com>
Tested-by: Dave Thaler <dthaler@microsoft.com>
-
junghun kim authored
Change-Id: I659d9e88f2d189de15d9817e304fd7d939a73765 Signed-off-by:
junghun kim <jhun1105.kim@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17799Tested-by:
Dmitriy Zhuravlev <d.zhuravlev@samsung.com> Reviewed-by:
-
KIM JungYong authored
Unit test of notification service sometimes failures due to time delay. In this patch, network related procedure(including multicast discovery) was removed on the c layer of notification service. Patch #2 Resolve build error in previous unittest. Patch #3 Apply changes about changed CA interface APIs. Remove checking resource type on the Presence callback. Change-Id: Ifa46c346fa6236266dc2a73a2f8d948c57d2f736 Signed-off-by:
-
- 13 Mar, 2017 7 commits
-
-
Philippe Coval authored
csdk: Link to oc as used Observed issue is when building with yocto (master): libresource_directory.so: \ undefined reference to \ `OC::MessageContainer::representations() const Note, Targets supporting RD are aligned to: resource/csdk/resource-directory/SConscript ( https://gerrit.iotivity.org/gerrit/14059 ) And it would worth to extent platform support in later patches. Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: I930bc6bcbbf052eddb679ffea9eb822300000001 Signed-off-by:
-
George Nash authoredThe -Wimplicit-function-delaration waring was caused by the compiler not seeing the isxdigit function. The function is part of the ctype.h header. Change-Id: Idc3498110082c55554b4a032aa945ba0082a6f98 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17811Reviewed-by: -
Todd Malsbary authored
The intent of this API is to stop responding to /oic/res responses when resources are registered with a resource directory. Stopping all multicast reception prevents ownership transfer from working. Bug: https://jira.iotivity.org/browse/IOT-1906 Change-Id: I01e183b6f5a249a4d0e32baf14f542774a3ca0cb Signed-off-by:
Todd Malsbary <todd.malsbary@intel.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17633Tested-by:
-
jihwan.seo authored
Lite Device has always requirement to reduce memory size. Also LOGGING build option is not enough for the requirement. Thru, we need to provide to select log which can include in binary. ex) LOGGING=true -> about 2267kbyte (libconnectivity_abstraction, liboctbstack, libocsrm, libroutingmanager) LOGGING=true LOG_LEVEL=ERROR -> 2184kbyte => about 82kbyte saving Change-Id: I1158de8739b2cd8fa961ad6fc3ff8899c410cbce Signed-off-by: -
George Nash authored
-Wunused-parameter - fixed using the OC_UNUSED macro -Wtype-limits - the statment `if (dimensions[0] >= 0)` is always true because the `dimensions` param is size_t which is never negative. Since its always true the if statment was removed. Change-Id: I08c9e68e9c688cd9f31bee8d9368a4eec6c8cc01 Signed-off-by:
George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17815Tested-by: -
Philippe Coval authored
As set in shared file: resource/c_common/SConscript Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: I19502dec6cfbafc20cf9cfc8ef392174811992dd Signed-off-by:
-
Larry Sachs authored
Fixes [IOT-1908]. The recent commit of https://gerrit.iotivity.org/gerrit/#/c/17685/ requires OcPlatform.start() be called after OcPlatform.configure() Change-Id: I5b721ff24c4b673b5741c14f4c7ed3331b9e536d Signed-off-by:
Larry Sachs <larry.j.sachs@intel.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17809Tested-by:
George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
-
- 11 Mar, 2017 1 commit
-
-
Philippe Coval authored
A regression has been reported on discovery when large payloads are used. After investigation in blockwise feature, it appeared that regression occurred with this change: https://gerrit.iotivity.org/gerrit/#/c/17419/ Author assumed that payload should fit into CoAP PDU (1400c), which is against the blockwise feature's design. Adjusting those tests, seems to fix the problem. Bug: https://jira.iotivity.org/browse/IOT-1902 Change-Id: I0aa6d97de0987d13c54b426b537b5d83235517b7 Thanks-to: Pawel Winogrodzki <pawelwi@microsoft.com> Signed-off-by:
-
- 10 Mar, 2017 4 commits
-
-
ChaJiWon authored
When called OCStartPresence() second, OCStartPresence() returns error. Fixed presenceState variable to OC_PRESENCE_UNINITIALIZED. Change-Id: I089c826f4105eb3aaf835a8feda4c10b848ebd5d Signed-off-by:
ChaJiWon <jw_wonny.cha@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/17623Tested-by:
-
Philippe Coval authored
It is strongly recommended to rely on scons, if not possible, this can be done differently using this script. For more details about building IoTivity please check: https://wiki.iotivity.org/build The main purpose of prep.sh, is for continuous integration experiments for Tizen platform, but could be used for others too. Bug: https://jira.iotivity.org/browse/IOT-1600 Change-Id: I8b07fdc4762baf403079c8816fc3017372627ef7 Signed-off-by:
-
Mats Wichmann authored
Change-Id: I6c2b42a0b3a411c7d9693eaeeb6ae05eb06ef9c8 Signed-off-by:
-
Kevin Kane authored
Conflicts: Restore OIC_JSON_SUBJECT_NAME definition in srmresourcestrings.{c,h} Warning settings in resource/csdk/security/SConscript Change-Id: Iabb48389b8aaa1ffa480287979df264e30bfac89 Signed-off-by:
-
