- 26 Oct, 2017 2 commits
-
-
Dan Mihai authored
mbedtls_pk_parse_key was not able to parse the key converted to DER by GetDerKey(). It encountered in the DER an unexpected key format version. However, mbedtls_pk_parse_key is able to parse correctly the original PEM format of the same key. This patch allows CT1.7.4.5 to establish a connection to an IoTivity server. This test case still fails later on - to be investigated. Change-Id: I933ea9d3b761ed159faa2c4f371890e477caf23f Signed-off-by:
Dan Mihai <Daniel.Mihai@microsoft.com>
-
Nathan Heldt-Sheller authored
These functions were applied at incorrect times (e.g. if a normal Update was rejected due to read-only properties during OTM, the entire system would "restore" to a wrong state). They were also wrong, in that they restored some values, left others unchanged, and set others to wrong values (e.g. presumed JustWorks OTM). Also, the duplicate message logic was not being used to any consistent effect and causing warnings. It's also completely optional and so was removed. Change-Id: I23d23f946fbafe02cdc2d2ac6ac46abcedd1f149 Signed-off-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
- 25 Oct, 2017 3 commits
-
-
George Nash authored
Documented all the functions referencing the native code. Note the OcProvisioning setPinType method had a return value int. The was returning the return value of the native call that was the status. Due to the way the code was writen the only value that could be returned was when things worked as expected. All other values were thrown so the return value was un-needed. The function was changed to have a return type of void. Bug:https://jira.iotivity.org/browse/IOT-2838 Change-Id: I3b5955a336661574dde9f70c87b6ead3dcd5ea7b Signed-off-by:
George Nash <george.nash@intel.com>
-
George Nash authored
The coding standard states: Code must compile with no warnings. Without flags forcing warnings off. see: https://wiki.iotivity.org/iotivity_c_coding_standards Its possible that using an untested version of gcc could result in build warings that are not yet fixed. For this reason the build option ERROR_ON_WARN was added to make it possible to turn off the -Werror flag. This should only be used locally an not changed on the CI build. Due to some bugs in older version of gcc some warnings are forced off when using an older version of gcc. This change will force code to follow the coding standard of building with no warnings. The coapHttpParser code produces a build warning that currently is not solved. When building the coap_http_proxy library the -Werror build flag is removed. Don't use the -Werror build option for extlib yaml code. Don't use the -Werror build option for coap library Change-Id: Ifcc25ed7e5b8637ac4383a7bfa51ace105ed9458 Signed-off-by:
George Nash <george.nash@intel.com>
-
Nathan Heldt-Sheller authored
See JIRA IOT-2830 for more information. Change-Id: If043f6705ccdede4630b469c13e1933a2b53af16 Signed-off-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
- 24 Oct, 2017 3 commits
-
-
George Nash authored
Bug: https://jira.iotivity.org/browse/IOT-2455 Change-Id: I1415ec047ebc8ce4f2679b8789a104c627ec2db4 Signed-off-by:
George Nash <george.nash@intel.com>
-
Rami Alshafi authored
The default arch for the raspberry pi board is either armv6l or armv7l depending on board hardware version. Neither of them are included in the valid values for the TARGET_ARCH build option. The current workaround is to pass TARGET_ARCH=arm to the build command. This change will enable the default arch. Change-Id: I7f07734f5e06d79d13275254fb01f924227e229a Signed-off-by:
Rami Alshafi <ralshafi@vprime.com>
-
Oleh Vasyliev authored
Change-Id: Ie7b0a00963b22ee1189918ed67ed64ae05f500cf Signed-off-by:
Oleh Vasyliev <o.vasyliev@samsung.com>
-
- 23 Oct, 2017 4 commits
-
-
Nathan Heldt-Sheller authored
The Update handler is still doing things such as self-updating /doxm.rowneruuid or /doxm.owned. Also, the logic for determining OTM start/stop is wrong. This patch cleans up the JustWorks flow as a template, and the same fix will be applied to Random PIN and Cert-based once verified and reviewed. Change-Id: Ieb68911de87cf816597352aec760b3ef85baa87d Signed-off-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
Nathan Heldt-Sheller authored
The fix to /cred.rowneruuid (from many to one) means we have to reset the single global rowneruuid also. Change-Id: I309e5bfe9926290785d4943d2b9358fc06448a20 Signed-off-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
imtiaz.h authored
1. for selectedDeviceInfo = NULL api returns OC_STACK_INVALID_PARAM Change-Id: Idb316438a76d70fcc7a91a2e119aadd0c771bde7 Signed-off-by:
imtiaz.h <imtiaz.h@samsung.com>
-
Harry authored
Java ESResult is not in sync with C++ SDK ESResult enum values. Change-Id: I0ab0e1ba88858fc8c511a56d046d40c1708760cd Signed-off-by:
Harry <h.marappa@samsung.com>
-
- 21 Oct, 2017 1 commit
-
-
Nathan Heldt-Sheller authored
A recent patch over-wrote the fix to 2806 (patch 22855) so this is just a re-creation of 22855. However gerrit can't figure out how to re-apply 22855, and I don't know how to force it, so I'm just creating a new patch. Change-Id: I5c4b67a3cdfa1f9a4368fc8f7b24203da1644524 Signed-off-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
- 20 Oct, 2017 7 commits
-
-
George Nash authored
the -Werror=unused-result is due to not checking the return value when using scanf. This error is specific to certan versions of the compiler and may not occure on all systems. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: Ifcaa05f7f7df69da84bd3a514ad3f29a63955b02 Signed-off-by:
George Nash <george.nash@intel.com>
-
Todd Malsbary authored
Bug: https://jira.iotivity.org/browse/IOT-2819 Change-Id: I43631fe750b529b6e90dd625c160717c854a2100 Signed-off-by:
Todd Malsbary <todd.malsbary@intel.com>
-
Ziran Sun authored
Retest OCRepresentationSubscript.Boolean unit test. Change-Id: Ibe291d4b0f6371235ba7397b186a87ef8939beab Signed-off-by:
Ziran Sun <ziran.sun@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/10811Reviewed-by:
Phil Coval <philippe.coval@osg.samsung.com> Tested-by:
jenkins-iotivity <jenkins@iotivity.org> Reviewed-by:
Ashok Babu Channa <ashok.channa@samsung.com> (cherry picked from commit fa632fb3)
-
George Nash authored
Fixed -Werror=unused-const-variable= found in routingtablemanager.c the USECS_PER_SEC was not used anywhere and was removed. Fixed -Werror=format= found in routingmanager.c current time is a uint64 from inttypes.h %llu is long long unsigned. C99 spec suggests the type long long int should be at least 64 bits but may be more. On some platfroms it might be 128-bits. In printf %lld could be interpreted as 64-bits or 128-bits which could result in undefined behavior. The PRIu64 macro from inttypes will always be interpreted as 64-bits by printf. Change-Id: Iaf45d5a8382c4af8f3db973700db1d90b4472cc1 Signed-off-by:
George Nash <george.nash@intel.com>
-
George Nash authored
The static functions: CAInitLEServerQueue CAInitLEServerReceiverQueue CAInitLEServerSenderQueue CALEServerDataReceiverHandler CALEServerSendDataThread Are all only called if both ROUTING_GATWAY and SINGLE_THREAD are not defined. When the are not called gcc will produce the -Werror=unused-function warning. Rather than spatering the macros all over the file I moved all of the functions into a single block The code in the functions are not modified. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: Ic15e4e91028b87fb8d2680f2e64c724d1fae25cc Signed-off-by:
George Nash <george.nash@intel.com>
-
Nathan Heldt-Sheller authored
There are a few cases of missing implicit access that are added by this patch: 1) DOXS has access to all SVRs 2) AMS and CMS have access to /pstat Change-Id: I7eebc86c88b392dc2a6447c64f3a216afee70b19 Signed-off-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
Gabriel Schulhof authored
OCBindResourceInsToResource and OCGetResourceIns are only defined if RD_MODE is either "client" or "server", but not if it is "none". Thus, octbstack_product.def must not include those functions. Bug: https://jira.iotivity.org/browse/IOT-2500 Change-Id: I88bbf033006e82d1655d39d7f3127a1e40a1d4e7 Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/21395Reviewed-by:
Alex Kelley <alexke@microsoft.com> Tested-by:
jenkins-iotivity <jenkins@iotivity.org> Reviewed-by:
Dan Mihai <Daniel.Mihai@microsoft.com> (cherry picked from commit f4fb7430)
-
- 19 Oct, 2017 19 commits
-
-
George Nash authored
The CAInitLEServerQueues functions was moved moved within the ifndef SINGLE_THREAD macros since that is the only time the function is used. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: Ic942b096eb5bffd2ac17b613afebbfa947a158b7 Signed-off-by:
George Nash <george.nash@intel.com>
-
Dan Mihai authored
Change-Id: I91e0210a03683041600ff26e3fd09b5bde19123d Signed-off-by:
Dan Mihai <Daniel.Mihai@microsoft.com>
-
Oleksandr Dmytrenko authored
Fixed doxm POST handler modifies values without request from OBT Change-Id: I4631063002ebf830160b772f55c9a9f139b78dbc Signed-off-by:
Oleksandr Dmytrenko <o.dmytrenko@samsung.com> Signed-off-by:
Dan Mihai <Daniel.Mihai@microsoft.com>
-
George Nash authored
When built with build option SECURED=0 some functions are no longer used due to preprocessor macros. The functions WithinBounds and IsEmptyCred were moved within the if defined(__WITH_DTLS__) || defined(__WITH_TLS__) macro Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: I9c0e3fa57dee5531bd9661216f2b5160fb002f33 Signed-off-by:
George Nash <george.nash@intel.com>
-
George Nash authored
Fix the simplerserver acls so the non-secure run option will also work as well as the secure option. Bug: https://jira.iotivity.org/browse/IOT-2443 Change-Id: I27b8aaf3db0ece5ad08a16d451cecb26fe8cd3a7 Signed-off-by:
George Nash <george.nash@intel.com>
-
Nathan Heldt-Sheller authored
The Parameter "p" in the /pstat "dos" Property is meant to be read-only in every Device Onboarding State. This fixes the Update handler to treat "p" as read-only. It also fixes the pstat->CBOR marshaling code to provide the option to omit "p". And it updates the provisioningclient code to omit "p" from Updates to /pstat. Change-Id: I25a92bd33e5476d7d5896021e42102762deb6c31 Signed-off-by:
Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
-
Dan Mihai authored
Avoid using NULL event handle during catests. Change-Id: I7e7d2ef95e8141082f7694735f20a77d773b42b4 Signed-off-by:
Dan Mihai <Daniel.Mihai@microsoft.com>
-
George Nash authored
Fix the missing-field-initializers warning in the simulator code. OCDeviceInfo contains four values not two. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: Ifab39f7a5eb054eeb301cece2123e9cc6d19011c Signed-off-by:
George Nash <george.nash@intel.com>
-
Philippe Coval authored
Fix ~2Kb MLK in rd_client.c: 2,208 bytes in 1 blocks are definitely lost in loss record 1,056 of 1,061 oic_malloc.c:102: OICCalloc cainterfacecontroller.c:643: CAGetNetworkInfo canetworkconfigurator.c:297: CAGetNetworkInformationInternal caconnectivitymanager.c:298: CAGetNetworkInformation rd_client.c:266: RDPublishPayloadCreate rd_client.c:383: OCRDPublishWithDeviceId rd_client.c:139: OCRDPublish rdtests.cpp:253: RDTests_RDPublishMultipleResources_Test::TestBody() It was detected in: https://gerrit.iotivity.org/gerrit/#/c/22005/ Bug: https://jira.iotivity.org/browse/IOT-1684 Change-Id: I5c59f998a5b1f616fbcde27d3a215694c5bd0422 Origin: https://gerrit.iotivity.org/gerrit/#/c/22051/Signed-off-by:
Philippe Coval <philippe.coval@osg.samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/22051Tested-by:
jenkins-iotivity <jenkins@iotivity.org> Reviewed-by:
Larry Sachs <larry.j.sachs@intel.com> Reviewed-by:
Mats Wichmann <mats@linux.com> Reviewed-by:
Habib Virji <habib.virji@samsung.com> Reviewed-by:
Ashok Babu Channa <ashok.channa@samsung.com> (cherry picked from commit 3a7fb541)
-
Jaehong Jo authored
Change-Id: I3bde95b535fcbfd3290a7b9ae0610c3e9333be7a Signed-off-by:
Jaehong Jo <jaehong.jo@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/20299Tested-by:
jenkins-iotivity <jenkins@iotivity.org> Reviewed-by:
Dan Mihai <Daniel.Mihai@microsoft.com> (cherry picked from commit 94429e77)
-
George Nash authored
Remove the unused-parameter warning from the simulator code Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: Id1c3757e41443ae53126ac1ef1117e387f564327 Signed-off-by:
George Nash <george.nash@intel.com>
-
George Nash authored
Fixed the switch warning in the simulator code. In the request_model_builder the other posible values for the switch are not expected if they occure print an error and exit assert. Just in case it is a release build an empty string is returned. In simulatory_utils the un-handled case statments were added to the switch. Bug: https://jira.iotivity.org/browse/IOT-2539 Change-Id: Iebb79bd22410727c65c33ed73ec8704a1b8a33a4 Signed-off-by:
George Nash <george.nash@intel.com>
-
abitha.s authored
Change-Id: I4aa2f68b36b70946c0bcee0e9da04feef596ea85 Signed-off-by:
abitha.s <abitha.s@samsung.com>
-
Philippe Coval authored
Bug: https://jira.iotivity.org/browse/IOT-2450 Change-Id: Ie747f5512d12f782a3331c8eaf00984a63605b85 Origin: https://gerrit.iotivity.org/gerrit/#/c/22695/Signed-off-by:
Philippe Coval <philippe.coval@osg.samsung.com>
-
Philippe Coval authored
As not supported on clang-3.5 Bug: https://jira.iotivity.org/browse/IOT-1745 Change-Id: I7bb4f53a0a0e2eba56e670f87ac163a211173fb6 Signed-off-by:
Philippe Coval <philippe.coval@osg.samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/21561Reviewed-by:
George Nash <george.nash@intel.com> Tested-by:
jenkins-iotivity <jenkins@iotivity.org> Reviewed-by:
Dan Mihai <Daniel.Mihai@microsoft.com> (cherry picked from commit 99bfbb05)
-
Philippe Coval authored
This change is harmless and done to test build process Bug: https://jira.iotivity.org/browse/IOT-2279 Change-Id: Ia8889790f19d6e02a0fc5c2d857ac19e717e2ec4 Signed-off-by:
Philippe Coval <philippe.coval@osg.samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/19987Tested-by:
jenkins-iotivity <jenkins@iotivity.org> (cherry picked from commit 68649b7a)
-
Philippe Coval authored
Bypass the part which is crashing clang-3.5, and use reference Change-Id: I8578509cb642be5d8dbaf1d5fbcdd944377b0fc8 Signed-off-by:
Philippe Coval <philippe.coval@osg.samsung.com>
-
Harry authored
Changes are mostly related to indentation, adding curly braces to single line conditional blocks. Change-Id: I4fcade68805dc3c1a6970a34683e519708a609f7 Signed-off-by:
Harry <h.marappa@samsung.com>
-
Harry authored
Changes are mostly related to indentation, catching exception by reference-to-const. Change-Id: I3aa27b58f507551ed2ed677c4b2c89b151b87bf3 Signed-off-by:
Harry <h.marappa@samsung.com>
-
- 18 Oct, 2017 1 commit
-
-
Dan Mihai authored
Don't enable Just Works for the Random PIN sample, etc. Change-Id: I2109a1f8be41bef4c1672a35cfcffeb49ce28290 Signed-off-by:
Dan Mihai <Daniel.Mihai@microsoft.com> Bug: https://jira.iotivity.org/browse/IOT-2818
-