1. 12 Jul, 2018 1 commit
  2. 11 Jul, 2018 2 commits
  3. 10 Jul, 2018 2 commits
  4. 09 Jul, 2018 2 commits
    • Mats Wichmann's avatar
      Fix and clean up libcoap build · defb8442
      Mats Wichmann authored
      Most signficant change: when upstream libcoap is used (always true for
      Windows), do "git checkout" even if the desired tag is already in the
      repo, this should fix the case where the checkout is not up to date but
      the repo is, so no checkout is done.
      
      Minor changes:
      
      * The forked-coap case is moved to the top of if clauses for readability
        (before there might have been dozens of lines, then else: followed by
        two lines)
      * A bug where PREFIX rather than LIBPREFIX was fetched from the
        construction environment is fixed.
      * One of the config file names was simplified a bit.
      * The Glob call to determine source files to build is now wrapped in a
        try block, the current Tizen SCons is so old it does not support the
        "exclude" attribute.
      * A check for the Tizen case ("don't use git commands in sconscript")
        is added.
      * Comment updates
      
      Change-Id: Icec0d1a9c5cbf20f0adbc32745486333766234e7
      Signed-off-by: default avatarMats Wichmann <mats@linux.com>
      defb8442
    • Nathan Heldt-Sheller's avatar
      [IOT-3098] create Resource as OC_SECURE by default · de28e6c2
      Nathan Heldt-Sheller authored
      The current behavior of OCCreateResource() is to create an unsecure
      Resource by default.  However it should be flipped, so that creating
      an unsecure Resource requires explicit intention.  This may fix
      IOT-3098, where several Resources are unsecure that should not be.
      
      Change-Id: I35083f5e240ecbc6d1c731642b5c8124c5283712
      Signed-off-by: Nathan Heldt-Sheller's avatarNathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
      de28e6c2
  5. 29 Jun, 2018 1 commit
  6. 28 Jun, 2018 1 commit
  7. 26 Jun, 2018 1 commit
  8. 25 Jun, 2018 1 commit
  9. 24 Jun, 2018 1 commit
    • Mats Wichmann's avatar
      Update upstream-libcoap to IoTivity-1.4 tag · 01f7d79e
      Mats Wichmann authored
      New coap code is needed so update the tag to look for. Fixes the
      failed Windows CI builds in https://gerrit.iotivity.org/gerrit/#/c/25491/
      
      Other changes:
      * The SConscript adds the WITH_WS definition to the build
      * Quiet the windows warning on size mismatches (W4267)
      - Note these two indicate problems introduced by iotivity patches to
      the dthaler libcoap fork, and the problems themselves should be fixed
      (WITH_WS is correct, but the logic in the case statement is not, so the
      absence of the flag caused build failures which are now covered up -
      this one is IOT-3103)
      
      * libcoap script checked tag in last line of commit log, that's fragile,
      so changed to use git log instead.
      
      * The standard check for the alternate way the code may be populated
      is added.  This is used for Tizen builds.
      
      * A little restructuring for readability (message strings defined away
      from the code so we can read the code), and the "git checkout" is now
      actually error-checked.
      
      Bug: https://jira.iotivity.org/browse/IOT-3044
      Change-Id: I331ef9ed19d128ff975d150f6c0058eff64b59ff
      Signed-off-by: default avatarMats Wichmann <mats@linux.com>
      01f7d79e
  10. 22 Jun, 2018 1 commit
  11. 19 Jun, 2018 1 commit
  12. 18 Jun, 2018 1 commit
  13. 14 Jun, 2018 2 commits
    • Biman Paul's avatar
      [IOT-3083] IUT crash while batch update by href · 0bba2f80
      Biman Paul authored
      IUT crash occured while executing CTT Server Testcase 1.2.13
      Batch update by href. Double free occured for server request
      handle. Once in HandleSingleResponse() and another in
      HandleAggregateResponse().
      6  0x00007ffff705f452 in OICFree (ptr=0x7fffd400d6f0)
          at resource/c_common/oic_malloc/src/oic_malloc.c:150
      7  0x00007ffff729da8e in DeleteServerRequest (serverRequest=0x7fffd40008c0)
          at resource/csdk/stack/src/ocserverrequest.c:412
      8  0x00007ffff729eaf1 in HandleAggregateResponse (ehResponse=0x7fffe8dcc450)
          at resource/csdk/stack/src/ocserverrequest.c:892
      
      Change-Id: I69ca3d5a0fe59626b545047530b68fd0cfdd27ad
      Signed-off-by: default avatarBiman Paul <biman.paul@samsung.com>
      0bba2f80
    • Oleksandr Andrieiev's avatar
      [CR2390] Identity spoofing/privelege escalation · bc8c9fdc
      Oleksandr Andrieiev authored
      For secure connections that use certificates the SubjectUUID
      is retrieved from leaf certificate's CN. However, there is
      no binding mechanism between Root CA and Device Id that it
      can generate certificates for. Root CAs can issue certificates
      with arbitrary UUIDs, which can be used to impersonate another
      Device.
      
      The fix adds callback to the certificate chain validation
      function. This callback collects single-linked list of all
      UUIDs associated with the certificate in cred entries.
      When leaf certificate is reached, UUID of Device is retrieved
      and matched against static list. If no matching UUID is
      found, connection should be rejected.
      
      Bug: https://jira.iotivity.org/browse/IOT-3087
      Change-Id: I20333c980226dc6a0c257dc36aab1502202993d9
      Signed-off-by: Oleksandr Andrieiev's avatarOleksandr Andrieiev <o.andrieiev@samsung.com>
      bc8c9fdc
  14. 08 Jun, 2018 1 commit
  15. 07 Jun, 2018 1 commit
  16. 04 Jun, 2018 1 commit
  17. 30 May, 2018 2 commits
  18. 28 May, 2018 1 commit
  19. 24 May, 2018 1 commit
    • Veeraj Khokale's avatar
      [IOT-3044] No response for Ping message · 6b637551
      Veeraj Khokale authored
      TCP adapter disconnects the session whenever
      the data to be sent has an empty payload.
      Since ping messages and signaling messages
      need to have an empty payload they are dropped.
      Fix this by checking if the message is a signaling
      message before dropping it.
      
      Change-Id: I1cfad27fcfd5cf3a42510412e6555b84ea905259
      Signed-off-by: default avatarVeeraj Khokale <veeraj.sk@samsung.com>
      (cherry picked from commit c7dce6b5)
      6b637551
  20. 23 May, 2018 1 commit
  21. 22 May, 2018 1 commit
  22. 18 May, 2018 1 commit
  23. 17 May, 2018 1 commit
  24. 16 May, 2018 2 commits
  25. 07 May, 2018 1 commit
  26. 04 May, 2018 1 commit
  27. 20 Apr, 2018 2 commits
  28. 19 Apr, 2018 1 commit
  29. 18 Apr, 2018 5 commits
    • Mats Wichmann's avatar
      static analysis: buffer size violations · def7f5fe
      Mats Wichmann authored
      fix reported "might leave destination string unterminated" when
      using strncpy and the size argument is the size of the desitnation
      buffer. There are several ways to fix, but the IoTivity API OCStrncpy
      adjusts the size before calling the underlying fuction and so fixes
      the problem. This is the coding standard recommendation anyway.
      
      for instances in examples, oic_string.h is not in the public API,
      so just fix up the counts.
      
      bridging/common/messageHandler.cpp had a third strncpy which was not
      flagged - but it was using a constant that did not match the size
      in the destination - MPMResourceList.href is size MPM_MAX_URI_LEN,
      so this was adjusted.
      
      service/notification/src/consumer/NSConsumerCommon.c had this construct:
         sizeof(char) * NS_DEVICE_ID_LENGTH
      in several places (one of which was one of these strncpy calls that
      was changed). the instances were shortened NS_DEVICE_ID_LENGTH for
      readability. This is not fixing any reported problem and can be
      dropped if it bothers reviewers.
      
      Change-Id: I8f22f7dd704849477dad0dd1f16cd9276ebf1d04
      Signed-off-by: default avatarMats Wichmann <mats@linux.com>
      def7f5fe
    • Oleksandr Dmytrenko's avatar
      [IOT-3022] · 5dbe9adc
      Oleksandr Dmytrenko authored
      outdated cloud sample removed 
      
      Change-Id: I8d8991d1e6f5f0879c3a168b7807680710b2e0a2
      Signed-off-by: default avatarOleksandr Dmytrenko <o.dmytrenko@samsung.com>
      5dbe9adc
    • Oleksandr Dmytrenko's avatar
      [IOT-3022] · 37cb9379
      Oleksandr Dmytrenko authored
      a) cloud resource unittests
      b) amacl resource make cbor fix
      
      Change-Id: Ib4d56f3105e060656d52f5b0b498ae188fe42c03
      Signed-off-by: default avatarOleksandr Dmytrenko <o.dmytrenko@samsung.com>
      37cb9379
    • Kush's avatar
      Enhanced comment ratio for le_adapter · 417a8cb0
      Kush authored
      Change-Id: I893246e60d959efa65741635e8e8b286e05a0b4d
      Signed-off-by: Kush's avatarKush <kush.agrawal@samsung.com>
      417a8cb0
    • Aleksey's avatar
      [IOT-3022] Plugfest hotfix 3 · af3a37e3
      Aleksey authored
      - add coapcloudconf uri to DCR list
      - start cloud signin on RFNOP, not on RFPRO
      
      Change-Id: Id52b650a23c82830a2641d5e0e5b94af79aa0c27
      Signed-off-by: Aleksey's avatarAleksey Volkov <a.volkov@samsung.com>
      af3a37e3