[IOT-2218] Encode empty arrays as 80 ([]), not 80 F6 ([null]).

Bug: https://jira.iotivity.org/browse/IOT-2218
Change-Id: Iaa0086ac69d02d2d36169efb3f304c71cefc7425
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19689Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>

resource/csdk/stack/src/ocpayloadconvert.c

@@ -777,55 +777,46 @@ static int64_t OCConvertArray(CborEncoder *parent, const OCRepPayloadValueArray
     CborEncoder array;
     err |= cbor_encoder_create_array(parent, &array, valArray->dimensions[0]);
     VERIFY_CBOR_SUCCESS(TAG, err, "Failed creating rep array");
-    // empty array
-    if (valArray->dimensions[0] == 0)
+    for (size_t i = 0; i < valArray->dimensions[0]; ++i)
     {
-        err |= OCConvertArrayItem(&array, valArray, 0);
-        VERIFY_CBOR_SUCCESS(TAG, err, "Failed adding rep array value");
-    }
-    else
-    {
-        for (size_t i = 0; i < valArray->dimensions[0]; ++i)
+        if (0 != valArray->dimensions[1])
         {
-            if (0 != valArray->dimensions[1])
-            {
-                CborEncoder array2;
-                err |= cbor_encoder_create_array(&array, &array2, valArray->dimensions[1]);
-                VERIFY_CBOR_SUCCESS(TAG, err, "Failed creating rep array2");
+            CborEncoder array2;
+            err |= cbor_encoder_create_array(&array, &array2, valArray->dimensions[1]);
+            VERIFY_CBOR_SUCCESS(TAG, err, "Failed creating rep array2");
 
-                for (size_t j = 0; j < valArray->dimensions[1]; ++j)
+            for (size_t j = 0; j < valArray->dimensions[1]; ++j)
+            {
+                if (0 != valArray->dimensions[2])
                 {
-                    if (0 != valArray->dimensions[2])
-                    {
-                        CborEncoder array3;
-                        err |= cbor_encoder_create_array(&array2, &array3, valArray->dimensions[2]);
-                        VERIFY_CBOR_SUCCESS(TAG, err, "Failed creating rep array3");
+                    CborEncoder array3;
+                    err |= cbor_encoder_create_array(&array2, &array3, valArray->dimensions[2]);
+                    VERIFY_CBOR_SUCCESS(TAG, err, "Failed creating rep array3");
 
-                        for(size_t k = 0; k < valArray->dimensions[2]; ++k)
-                        {
-                            err |= OCConvertArrayItem(&array3, valArray,
+                    for(size_t k = 0; k < valArray->dimensions[2]; ++k)
+                    {
+                        err |= OCConvertArrayItem(&array3, valArray,
                                 j * valArray->dimensions[2] +
                                 i * valArray->dimensions[2] * valArray->dimensions[1] +
                                 k);
-                            VERIFY_CBOR_SUCCESS(TAG, err, "Failed adding rep array3 value");
-                        }
-                        err |= cbor_encoder_close_container(&array2, &array3);
-                        VERIFY_CBOR_SUCCESS(TAG, err, "Failed closing rep array3");
-                    }
-                    else
-                    {
-                        err |= OCConvertArrayItem(&array2, valArray, i * valArray->dimensions[1] + j);
-                        VERIFY_CBOR_SUCCESS(TAG, err, "Failed adding rep array2 value");
+                        VERIFY_CBOR_SUCCESS(TAG, err, "Failed adding rep array3 value");
                     }
+                    err |= cbor_encoder_close_container(&array2, &array3);
+                    VERIFY_CBOR_SUCCESS(TAG, err, "Failed closing rep array3");
+                }
+                else
+                {
+                    err |= OCConvertArrayItem(&array2, valArray, i * valArray->dimensions[1] + j);
+                    VERIFY_CBOR_SUCCESS(TAG, err, "Failed adding rep array2 value");
                 }
-                err |= cbor_encoder_close_container(&array, &array2);
-                VERIFY_CBOR_SUCCESS(TAG, err, "Failed closing rep array2");
-            }
-            else
-            {
-                err |= OCConvertArrayItem(&array, valArray, i);
-                VERIFY_CBOR_SUCCESS(TAG, err, "Failed adding rep array value");
             }
+            err |= cbor_encoder_close_container(&array, &array2);
+            VERIFY_CBOR_SUCCESS(TAG, err, "Failed closing rep array2");
+        }
+        else
+        {
+            err |= OCConvertArrayItem(&array, valArray, i);
+            VERIFY_CBOR_SUCCESS(TAG, err, "Failed adding rep array value");
         }
     }
     err |= cbor_encoder_close_container(parent, &array);